Skip to content

Cleaned up dependencies for TMVA tuts for avoiding race conditions #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peremato merged 2 commits into from
Mar 15, 2017
Merged

Cleaned up dependencies for TMVA tuts for avoiding race conditions #426

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24da4f0
Cleaned up dependencies for TMVA tuts
martinmine Mar 15, 2017
04a9713
Added missing tutorial- prefix on dependencies
martinmine Mar 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tutorials/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@ set(benchmarks-depends tutorial-hsimple
set(geom-na49view-depends tutorial-geom-geometry)
set(multicore-mt102_readNtuplesFillHistosAndFit-depends tutorial-multicore-mt101_fillNtuples)
set(multicore-mp102_readNtuplesFillHistosAndFit-depends tutorial-multicore-mp101_fillNtuples)
set(tmva-TMVAClassificationApplication-depends tutorial-tmva-TMVAClassification)

#--many roostats tutorials depending on having creating the file first with histfactory and example_combined_GaussExample_model.root
foreach(tname ModelInspector OneSidedFrequentistUpperLimitWithBands StandardBayesianMCMCDemo StandardBayesianNumericalDemo
Expand All @@ -276,11 +275,11 @@ endforeach()
#--dependency for TMVA tutorials
set (tmva-TMVAClassificationApplication-depends tutorial-tmva-TMVAClassification)
set (tmva-TMVAClassificationCategory-depends tutorial-tmva-TMVAClassification)
set (tmva-TMVAClassificationCategoryApplication-depends tutorial-tmva-TMVAClassificationCategory tutorial-tmva-TMVAClassificationCategory)
set (tmva-TMVAClassificationCategoryApplication-depends tutorial-tmva-TMVAClassificationCategory tutorial-tmva-TMVAClassificationApplication)
set (tmva-TMVAMulticlass-depends tutorial-tmva-TMVAMultipleBackgroundExample tutorial-tmva-TMVAClassificationCategory)
set (tmva-TMVAMulticlassApplication-depends tutorial-tmva-TMVAMulticlass)
set (tmva-TMVARegressionApplication-depends tutorial-tmva-TMVARegression)
set (tmva-TMVARegression-depends tutorial-tmva-TMVAMulticlass-depends)
set (tmva-TMVAMulticlassApplication-depends tutorial-tmva-TMVAMulticlass tmva-TMVAClassificationCategoryApplication)
Copy link
Contributor

@peremato peremato Mar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependent tests need to be specified with the full name: tuturial-tmva-TMVAClassificationCategoryApplication instead of tmva-TMVAClassificationCategoryApplication

set (tmva-TMVARegressionApplication-depends tutorial-tmva-TMVARegression tmva-TMVAMulticlassApplication)
Copy link
Contributor

@peremato peremato Mar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

set (tmva-TMVARegression-depends tutorial-tmva-TMVAMulticlass)


#---Loop over all tutorials and define the corresponding test---------
Expand Down