Cleaned up dependencies for TMVA tuts for avoiding race conditions #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peremato
reviewed
Mar 15, 2017
tutorials/CMakeLists.txt
Outdated
| set (tmva-TMVAMulticlassApplication-depends tutorial-tmva-TMVAMulticlass) | ||
| set (tmva-TMVARegressionApplication-depends tutorial-tmva-TMVARegression) | ||
| set (tmva-TMVARegression-depends tutorial-tmva-TMVAMulticlass-depends) | ||
| set (tmva-TMVAMulticlassApplication-depends tutorial-tmva-TMVAMulticlass tmva-TMVAClassificationCategoryApplication) |
Contributor
There was a problem hiding this comment.
The dependent tests need to be specified with the full name: tuturial-tmva-TMVAClassificationCategoryApplication instead of tmva-TMVAClassificationCategoryApplication
peremato
reviewed
Mar 15, 2017
tutorials/CMakeLists.txt
Outdated
| set (tmva-TMVARegressionApplication-depends tutorial-tmva-TMVARegression) | ||
| set (tmva-TMVARegression-depends tutorial-tmva-TMVAMulticlass-depends) | ||
| set (tmva-TMVAMulticlassApplication-depends tutorial-tmva-TMVAMulticlass tmva-TMVAClassificationCategoryApplication) | ||
| set (tmva-TMVARegressionApplication-depends tutorial-tmva-TMVARegression tmva-TMVAMulticlassApplication) |
Contributor
Author
|
I've commited a change fixing the issues @peremato pointed out. |
gganis
pushed a commit
to gganis/root
that referenced
this pull request
Apr 3, 2017
…oot-project#426) * Cleaned up dependencies for TMVA tuts * Added missing tutorial- prefix on dependencies
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the TMVA tutorials run in parallel and rely on the same generated file. Typically, one tutorial may depend on another one that generates the file. The top level ones did not depend on each other, thus running in parallel and causing a race condition. This PR should solve this issue by making them depend on each other.