Fixes some final 'after merge' comments in PR #394 #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on their scalar type
…ix support for Vc types
…ests. Start with a limited scope and just update Plane3D, Translation3D and Transformation3D
…ort vector Scalar types
…s. Works with Vc as long as Vc's headers are included first...
… expect speed up based on the SIMD register size is observed (with 10% safety factor)
…on a VM with poort SIMD support
|
Can one of the admins verify this patch? |
Member
|
Could you update to the newest master and create a new branch (opening a new PR based on that branch) which has only commit fixing the enable_if? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the enable_if pattern in the Vc Genvector test application, to match the changes made in #394 during review.