Skip to content

Conversation

@Teemperor
Copy link
Contributor

This patch improves the previous check whether the current compiler
is using an incompatible libstdc++ version or not.

@phsft-bot
Copy link

Build started

@vgvassilev
Copy link
Member

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Doracle=On -Dccache=Off -DVc=Off

@phsft-bot
Copy link

Build started

# Check if libstdc++ uses the new string ABI and fall back to the old one if yes.
# We have to check for this because on the nightly builds we have an old occi
# installation that uses the old ABI, which results in linking errors.
CHECK_CXX_SOURCE_COMPILES(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it would make more sense to move this check in CheckCompiler.cmake

@Teemperor Teemperor force-pushed the FixOCCILinkingError branch from be50f1f to c1a4afe Compare March 28, 2017 07:53
@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native

@vgvassilev
Copy link
Member

@phsft-bot build also on slc6/clang_gcc62 with flags -Dcxxmodules=On -Doracle=On -Dccache=Off

@phsft-bot
Copy link

Starting build on slc6/clang_gcc62, centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native and CMake flags -Dccache=Off -Dimt=OFF -Dcxxmodules=On -Doracle=On

This patch improves the previous check whether the current compiler
is using an incompatible libstdc++ version or not.
@Teemperor Teemperor force-pushed the FixOCCILinkingError branch from c1a4afe to ce7a90f Compare March 28, 2017 10:12
@vgvassilev
Copy link
Member

@phsft-bot build also on slc6/clang_gcc62 with flags -Dcxxmodules=On -Doracle=On -Dccache=Off

@phsft-bot
Copy link

Starting build on slc6/clang_gcc62, centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native and CMake flags -Dccache=Off -Dimt=OFF -Dcxxmodules=On -Doracle=On

@vgvassilev
Copy link
Member

It seems that the failures are not related to the PR. Merging.

@vgvassilev vgvassilev merged commit 07d6afd into root-project:master Mar 28, 2017
@Teemperor Teemperor deleted the FixOCCILinkingError branch March 28, 2017 13:49
gganis pushed a commit to gganis/root that referenced this pull request Apr 3, 2017
…-project#460)

This patch improves the previous check whether the current compiler
is using an incompatible libstdc++ version or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants