[modules][cxxmodules] Improve the layering of our special modules. #1412

vgvassilev · 2017-12-02T20:27:40Z

kTRUE and kFALSE were moved in RtypesCore.h which makes the move possible.

vgvassilev · 2017-12-02T20:28:19Z

@phsft-bot build just on slc6/gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-12-02T20:31:29Z

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

vgvassilev · 2017-12-02T20:32:14Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-12-02T20:32:26Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-12-02T21:24:58Z

Build failed on slc6/clang_gcc62.
See console output.

phsft-bot · 2017-12-02T21:27:52Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-12-02T22:26:54Z

Build failed on slc6/clang_gcc62.
See console output.

Errors:

include/RtypesCore.h:29:1: error: unknown type name 'class'
include/RtypesCore.h:59:9: error: unknown type name 'bool'
include/RtypesCore.h:87:23: error: use of undeclared identifier 'true'
include/RtypesCore.h:88:23: error: use of undeclared identifier 'false'
include/RtypesCore.h:98:32: error: unexpected type name 'UInt_t': expected expression
include/RtypesCore.h:99:32: error: unexpected type name 'Int_t': expected expression
include/RtypesCore.h:100:41: error: initializer element is not a compile-time constant
include/RtypesCore.h:102:32: error: unexpected type name 'ULong_t': expected expression
include/RtypesCore.h:103:32: error: unexpected type name 'Long_t': expected expression
include/RtypesCore.h:104:42: error: initializer element is not a compile-time constant

And 5 more

phsft-bot · 2017-12-03T13:23:57Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-12-03T13:49:23Z

Build failed on slc6/clang_gcc62.
See console output.

Errors:

include/RtypesCore.h:29:1: error: unknown type name 'class'
include/RtypesCore.h:59:9: error: unknown type name 'bool'
include/RtypesCore.h:87:23: error: use of undeclared identifier 'true'
include/RtypesCore.h:88:23: error: use of undeclared identifier 'false'
include/RtypesCore.h:98:32: error: unexpected type name 'UInt_t': expected expression
include/RtypesCore.h:99:32: error: unexpected type name 'Int_t': expected expression
include/RtypesCore.h:100:41: error: initializer element is not a compile-time constant
include/RtypesCore.h:102:32: error: unexpected type name 'ULong_t': expected expression
include/RtypesCore.h:103:32: error: unexpected type name 'Long_t': expected expression
include/RtypesCore.h:104:42: error: initializer element is not a compile-time constant

And 5 more

phsft-bot · 2017-12-04T09:26:49Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

vgvassilev · 2017-12-04T13:36:11Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-12-04T13:36:18Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-12-11T09:04:13Z

Build failed on slc6/clang_gcc62.
See console output.

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimap2Dict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module mapDict:

And 116 more

vgvassilev · 2017-12-13T09:16:36Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2017-12-13T09:20:36Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2017-12-13T10:10:50Z

Build failed on slc6/clang_gcc62.
See console output.

phsft-bot · 2018-01-29T17:22:23Z

Starting build on centos7/gcc49, mac1013/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu16/native, ubuntu16/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2018-01-29T18:14:54Z

Build failed on ubuntu16/native.
See console output.

Failing tests:

vgvassilev · 2018-01-29T21:00:26Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On

phsft-bot · 2018-01-29T21:00:56Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On
How to customize builds

vgvassilev · 2018-01-29T22:13:42Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-01-29T22:13:52Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-01-29T22:19:37Z

Build failed on slc6/clang_gcc62.
See console output.

Errors:

clang++: error: linker command failed with exit code 1 (use -v to see invocation)

vgvassilev · 2018-01-29T22:25:57Z

@phsft-bot build just on centos7/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-01-29T22:26:08Z

Starting build on centos7/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-01-29T22:55:21Z

Build failed on centos7/clang_gcc62.
See console output.

Errors:

/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/hashtable.h:179:24: error: default argument of '_Insert' must be imported from one of the following modules before it is required:
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/hashtable.h:220:54: error: '__node_base' is a protected member of 'std::__detail::_Hashtable_base<std::basic_string<char>, std::basic_string<char>, std::__detail::_Identity, std::equal_to<std::basic_string<char> >, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Hashtable_traits<true, true, true> >'
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/hashtable.h:221:56: error: '__bucket_type' is a protected member of 'std::__detail::_Hashtable_base<std::basic_string<char>, std::basic_string<char>, std::__detail::_Identity, std::equal_to<std::basic_string<char> >, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Hashtable_traits<true, true, true> >'
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/unordered_set.h:104:36: error: no type named 'hasher' in 'std::_Hashtable<std::basic_string<char>, std::basic_string<char>, std::allocator<std::basic_string<char> >, std::__detail::_Identity, std::equal_to<std::basic_string<char> >, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, true, true> >'
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/hashtable.h:179:24: error: default argument of '_Insert' must be imported from one of the following modules before it is required:
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/hashtable.h:220:54: error: '__node_base' is a protected member of 'std::__detail::_Hashtable_base<std::basic_string<char>, std::basic_string<char>, std::__detail::_Identity, std::equal_to<std::basic_string<char> >, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Hashtable_traits<true, true, true> >'
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/hashtable.h:221:56: error: '__bucket_type' is a protected member of 'std::__detail::_Hashtable_base<std::basic_string<char>, std::basic_string<char>, std::__detail::_Identity, std::equal_to<std::basic_string<char> >, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Hashtable_traits<true, true, true> >'
/usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/unordered_set.h:104:36: error: no type named 'hasher' in 'std::_Hashtable<std::basic_string<char>, std::basic_string<char>, std::allocator<std::basic_string<char> >, std::__detail::_Identity, std::equal_to<std::basic_string<char> >, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, true, true> >'

phsft-bot · 2018-01-30T12:42:59Z

Starting build on centos7/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-01-30T13:19:48Z

Build failed on centos7/clang_gcc62.
See console output.

Errors:

clang++: error: linker command failed with exit code 1 (use -v to see invocation)
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:

vgvassilev · 2018-02-16T21:16:22Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-02-16T21:18:16Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-02-16T21:51:07Z

Build failed on slc6/clang_gcc62.
See console output.

Errors:

include/RtypesCore.h:29:1: error: unknown type name 'class'
include/RtypesCore.h:59:9: error: unknown type name 'bool'
include/RtypesCore.h:87:23: error: use of undeclared identifier 'true'
include/RtypesCore.h:88:23: error: use of undeclared identifier 'false'
include/RtypesCore.h:98:32: error: unexpected type name 'UInt_t': expected expression
include/RtypesCore.h:99:32: error: unexpected type name 'Int_t': expected expression
include/RtypesCore.h:100:41: error: initializer element is not a compile-time constant
include/RtypesCore.h:102:32: error: unexpected type name 'ULong_t': expected expression
include/RtypesCore.h:103:32: error: unexpected type name 'Long_t': expected expression
include/RtypesCore.h:104:42: error: initializer element is not a compile-time constant

And 5 more

phsft-bot · 2018-02-16T22:06:30Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-02-16T23:35:49Z

Build failed on slc6/clang_gcc62.
See console output.

Errors:

303/1663 Test Create notebooks from tutorials #197: tutorial-dataframe-tdf013_InspectAnalysis .........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.54 sec
555/1663 Test Fix ABI compability when linking against OCCI when using clang. #460: tutorial-math-quasirandom .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.96 sec
586/1663 Test [WIP] Allow hadd to run in multiprocess mode #491: tutorial-multicore-mtbb201_parallelHistoFill ......................................................***Failed Error regular expression found in output. Regex=[: error:] 6.24 sec
698/1663 Test TMVA various fixes #610: tutorial-roostats-Zbi_Zgamma ......................................................................***Failed Error regular expression found in output. Regex=[: error:] 2.45 sec
711/1663 Test Extend TCanvasImp interface #622: tutorial-roostats-rs_numbercountingutils ..........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.85 sec
747/1663 Test First patch CNN #664: tutorial-tmva-keras-LaunchClasGUI .................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.12 sec
750/1663 Test Make NULL a nullptr var and deprecate it. #665: tutorial-tmva-keras-LaunchMultiGUI ................................................................***Failed Error regular expression found in output. Regex=[: error:] 15.86 sec
751/1663 Test Optimizations for TBufferMerger and parallel I/O in general #666: tutorial-tmva-keras-LaunchRegGUI ..................................................................***Failed Error regular expression found in output. Regex=[: error:] 4.80 sec
793/1663 Test Revert "First bunch of changes to fix the CMake build of the new llvm… #716: tutorial-dataframe-tdf002_dataModel-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 2.34 sec

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Thread:
/mnt/build/jenkins/workspace/root-pullrequests-build/root/net/http/civetweb/civetweb.c:2701:8: warning: implicit declaration of function 'pthread_setname_np' is invalid in C99 [-Wimplicit-function-declaration]

Failing tests:

And 28 more

There are three different kinds of header files in Core: * C headers - they can be included in C contexts * Config headers - they are supposed to be textually included in each TU. * No RTTI C++ headers - they can be built in non-rtti context which is needed for stage1 builds. The rest of the headers in Core require rtti in order to be built, either because they use typeinfo or exceptions. This patch structures the ROOT's special modules in that way allowing implicit module builds to be trigger from the right complation. For example, we cannot (and should not) trigger build of C++ module when compiling C code.

phsft-bot · 2018-02-17T21:34:30Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-02-17T21:41:05Z

Build failed on slc6/clang_gcc62.
See console output.

Errors:

ninja: error: loading 'build.ninja': No such file or directory

vgvassilev · 2018-02-17T21:48:23Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

phsft-bot · 2018-02-17T21:48:35Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

phsft-bot · 2018-02-17T21:53:08Z

Build failed on slc6/clang_gcc62.
See console output.

Errors:

ninja: error: loading 'build.ninja': No such file or directory

vgvassilev · 2018-02-17T22:01:03Z

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on -DCMAKE_GENERATOR="Unix Makefiles"

phsft-bot · 2018-02-17T22:01:15Z

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on -DCMAKE_GENERATOR="Unix Makefiles"
How to customize builds

phsft-bot · 2018-02-17T22:05:22Z

Build failed on slc6/clang_gcc62.
See console output.

Errors:

Error: could not load cache

vgvassilev · 2018-02-18T18:46:38Z

@phsft-bot build just on lcgapp-slc6-x86-64-25 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Droofit=Off -Dctest_test_exclude_none=on

vgvassilev · 2018-02-18T20:26:03Z

lcgapp-slc6-x86-64-26 yields different results. Running the ROOT master on that machine with the same build options gives the same test failures as this PR.

vgvassilev requested a review from Axel-Naumann as a code owner December 2, 2017 20:27

vgvassilev force-pushed the MoveThreadLocalStorageModule branch from c50a6a7 to 84291ed Compare December 2, 2017 21:27

vgvassilev requested a review from pcanal as a code owner December 2, 2017 21:27

vgvassilev force-pushed the MoveThreadLocalStorageModule branch from 84291ed to 30160b9 Compare December 3, 2017 13:23

vgvassilev force-pushed the MoveThreadLocalStorageModule branch from 30160b9 to cf14b50 Compare December 4, 2017 09:22

vgvassilev requested a review from amadio as a code owner December 4, 2017 09:22

vgvassilev force-pushed the MoveThreadLocalStorageModule branch from cf14b50 to 92f0514 Compare December 4, 2017 09:25

vgvassilev changed the title ~~[cxxmodules] Move ThreadLocalStorage to module ROOT_Types.~~ [modules][cxxmodules] Improve the layering of our special modules. Dec 4, 2017

amadio assigned vgvassilev Dec 4, 2017

vgvassilev force-pushed the MoveThreadLocalStorageModule branch from 92f0514 to 72e87e8 Compare January 29, 2018 17:22

vgvassilev force-pushed the MoveThreadLocalStorageModule branch from 72e87e8 to d96e298 Compare January 30, 2018 11:27

vgvassilev force-pushed the MoveThreadLocalStorageModule branch from d96e298 to cbec7cb Compare February 16, 2018 21:15

vgvassilev added 3 commits February 17, 2018 22:33

[cxxmodules] Preload the newly added special modules.

dd526a0

Remove redundant header.

c247e3e

vgvassilev force-pushed the MoveThreadLocalStorageModule branch from 671f273 to c247e3e Compare February 17, 2018 21:34

vgvassilev merged commit a404d0a into root-project:master Feb 18, 2018

[modules][cxxmodules] Improve the layering of our special modules. #1412

[modules][cxxmodules] Improve the layering of our special modules. #1412

Uh oh!

Conversation

vgvassilev commented Dec 2, 2017

Uh oh!

vgvassilev commented Dec 2, 2017

Uh oh!

phsft-bot commented Dec 2, 2017

Uh oh!

vgvassilev commented Dec 2, 2017

Uh oh!

phsft-bot commented Dec 2, 2017

Uh oh!

phsft-bot commented Dec 2, 2017

Uh oh!

phsft-bot commented Dec 2, 2017

Uh oh!

phsft-bot commented Dec 2, 2017

Errors:

Uh oh!

phsft-bot commented Dec 3, 2017

Uh oh!

phsft-bot commented Dec 3, 2017

Errors:

Uh oh!

phsft-bot commented Dec 4, 2017

Uh oh!

vgvassilev commented Dec 4, 2017

Uh oh!

phsft-bot commented Dec 4, 2017

Uh oh!

phsft-bot commented Dec 11, 2017

Warnings:

Uh oh!

vgvassilev commented Dec 13, 2017

Uh oh!

phsft-bot commented Dec 13, 2017

Uh oh!

phsft-bot commented Dec 13, 2017

Uh oh!

phsft-bot commented Jan 29, 2018

Uh oh!

phsft-bot commented Jan 29, 2018

Failing tests:

Uh oh!

vgvassilev commented Jan 29, 2018

Uh oh!

phsft-bot commented Jan 29, 2018

Uh oh!

vgvassilev commented Jan 29, 2018

Uh oh!

phsft-bot commented Jan 29, 2018

Uh oh!

phsft-bot commented Jan 29, 2018

Errors:

Uh oh!

vgvassilev commented Jan 29, 2018

Uh oh!

phsft-bot commented Jan 29, 2018

Uh oh!

phsft-bot commented Jan 29, 2018

Errors:

Uh oh!

phsft-bot commented Jan 30, 2018

Uh oh!

phsft-bot commented Jan 30, 2018

Errors:

Warnings:

Uh oh!

vgvassilev commented Feb 16, 2018

Uh oh!

phsft-bot commented Feb 16, 2018

Uh oh!

phsft-bot commented Feb 16, 2018

Errors:

Uh oh!

phsft-bot commented Feb 16, 2018

Uh oh!

phsft-bot commented Feb 16, 2018