Typos #553
Merged
Typos #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
clang-format can be ignored for comments. merging. |
Member
|
@pcanal, hm, the comments have trailing whitespaces. If we decide to ignore this, we should check next time somebody commits 'Whitespace fixes' in the comments... |
Member
|
@vgvassilev Indeed trailing space are not allowed in neither code nor comments ... In this case the output from travis showed also other type of changes (including alignment) and since the trailing spaces were not highlighted, it was very easy to overlook them ... (see for example the result of git diff that makes it very clear). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.