Skip to content

Optimize roofit includes. #5542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
linev merged 1 commit into from
May 5, 2020
Merged

Optimize roofit includes. #5542

linev merged 1 commit into from
May 5, 2020

Conversation

@hageboeck
Copy link
Member

@hageboeck hageboeck commented May 5, 2020 •
edited
Loading

Amended to not revert the changes to be added in PR #5514.

This should replace #5540

@hageboeck hageboeck requested a review from linev May 5, 2020 12:42
@hageboeck hageboeck requested a review from lmoneta as a code owner May 5, 2020 12:42
@hageboeck hageboeck self-assigned this May 5, 2020
@phsft-bot
Copy link

phsft-bot commented May 5, 2020

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@linev linev mentioned this pull request May 5, 2020
Closed
linev
linev approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@linev linev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

@linev @hageboeck
Optimize includes in roofit
01fc5b0 
Amended to not revert the changes to be added in PR root-project#5514.
@linev
Copy link
Member

linev commented May 5, 2020

@hageboeck You need rebase again :(

@hageboeck hageboeck force-pushed the linev/roofit_includes branch from af398b3 to 01fc5b0 Compare May 5, 2020 13:05
@phsft-bot
Copy link

phsft-bot commented May 5, 2020

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@hageboeck
Copy link
Member Author

hageboeck commented May 5, 2020

Yes, but it's only one conflict instead of >10. :-)

@linev linev mentioned this pull request May 5, 2020
Merged
@linev linev merged commit 33b1f38 into root-project:master May 5, 2020
@hageboeck hageboeck deleted the linev/roofit_includes branch May 5, 2020 15:40
@phsft-bot
Copy link

phsft-bot commented May 5, 2020

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-05-05T16:17:58.862Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:914 (message):

@phsft-bot
Copy link

phsft-bot commented May 5, 2020

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-2.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-05-05T16:24:13.207Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:914 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linev linev linev approved these changes

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

Assignees

@linev linev

@hageboeck hageboeck

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hageboeck @phsft-bot @linev