Optimize roofit includes.

roofit/histfactory/src/RooBarlowBeestonLL.cxx

@@ -21,9 +21,8 @@
 */
 
 #include <stdexcept>
-#include <math.h>
-
-#include "Riostream.h" 
+#include <cmath>
+#include <iostream>
 
 #include "RooFit.h"
 #include "RooStats/HistFactory/RooBarlowBeestonLL.h" 

roofit/roofit/src/RooLognormal.cxx

@@ -34,6 +34,7 @@ The parameterization here is physics driven and differs from the ROOT::Math::log
 #include "BatchHelpers.h"
 
 #include "TMath.h"
+#include "TClass.h"
 #include <Math/SpecFuncMathCore.h>
 #include <Math/PdfFuncMathCore.h>
 #include <Math/ProbFuncMathCore.h>

roofit/roofitcore/inc/RooAbsArg.h

@@ -17,22 +17,25 @@
 #define ROO_ABS_ARG
 
 #include "TNamed.h"
-#include "THashList.h"
+#include "TObjArray.h"
 #include "TRefArray.h"
 #include "RooPrintable.h"
 #include "RooSTLRefCountList.h"
 #include "RooAbsCache.h"
-#include "RooLinkedListIter.h"
 #include "RooNameReg.h"
+#include "RooLinkedListIter.h"
 #include <map>
 #include <set>
 #include <deque>
 #include <stack>
 
 #include <iostream>
 
-
+#ifndef R__LESS_INCLUDES
 #include "TClass.h"
+#include "THashList.h"
+#endif
+
 
 class TTree ;
 class RooArgSet ;

roofit/roofitcore/inc/RooFitResult.h

@@ -24,7 +24,7 @@
 #include "RVersion.h"
 #include "TMatrixFfwd.h"
 #include "TMatrixDSym.h"
-#include "TRootIOCtor.h"
+#include "TList.h"
 
 #include <vector>
 #include <string>

roofit/roofitcore/inc/RooSimPdfBuilder.h

@@ -18,10 +18,12 @@
 
 #include "Rtypes.h"
 #include "TObject.h"
+#include "TList.h"
 #include "RooArgSet.h"
 #include "RooArgList.h"
 #include "RooAbsData.h"
 #include <list>
+
 class RooSimultaneous ;
 class RooAbsPdf ;
 class RooCategory ;

roofit/roofitcore/src/Roo1DTable.cxx

@@ -26,17 +26,16 @@ equivalent of a plot. To create a table use the RooDataSet::table method.
 #include "Roo1DTable.h"
 
 #include "RooFit.h"
-#include "Riostream.h"
 #include "RooMsgService.h"
 #include "RooFitLegacy/RooCatTypeLegacy.h"
 
 #include "TString.h"
 #include "TMath.h"
 #include "TClass.h"
 
+#include <iostream>
 #include <iomanip>
 
-
 using namespace std ;
 
 ClassImp(Roo1DTable);

roofit/roofitcore/src/RooAbsCategory.cxx

@@ -59,6 +59,7 @@ the following replacements should be used:
 #include "TTree.h"
 #include "TLeaf.h"
 #include "ROOT/RMakeUnique.hxx"
+#include "TBranch.h"
 
 using namespace std;
 

roofit/roofitcore/src/RooAbsData.cxx

@@ -26,9 +26,9 @@ points for its contents and provides an iterator over its elements
 **/
 
 #include "RooAbsData.h"
-
 #include "RooFit.h"
-#include "Riostream.h"
+
+#include <iostream>
 
 #include "TBuffer.h"
 #include "TClass.h"

roofit/roofitcore/src/RooAbsTestStatistic.cxx

@@ -51,7 +51,7 @@ combined in the main thread.
 #include "RooAbsCategoryLValue.h"
 
 #include "TTimeStamp.h"
-
+#include "TClass.h"
 #include <string>
 
 using namespace std;

roofit/roofitcore/src/RooAddGenContext.cxx

@@ -31,7 +31,7 @@ with a probability proportional to its associated coefficient.
 #include "RooFit.h"
 
 #include "Riostream.h"
-
+#include "TClass.h"
 
 #include "RooMsgService.h"
 #include "RooAddGenContext.h"

roofit/roofitcore/src/RooCategory.cxx

@@ -86,10 +86,14 @@ for advanced uses of categories.
 #include "TBuffer.h"
 #include "TString.h"
 #include "ROOT/RMakeUnique.hxx"
+#include "TList.h"
+
+#include <iostream>
+#include <cstdlib>
 
 using namespace std;
 
-ClassImp(RooCategory); 
+ClassImp(RooCategory);
 
 std::map<std::string, std::weak_ptr<RooCategory::RangeMap_t>> RooCategory::_uuidToSharedRangeIOHelper; // Helper for restoring shared properties
 std::map<std::string, std::weak_ptr<RooCategory::RangeMap_t>> RooCategory::_sharedRangeIOHelper;

roofit/roofitcore/src/RooChi2Var.cxx

@@ -36,6 +36,7 @@
 #include "RooMsgService.h"
 
 #include "Riostream.h"
+#include "TClass.h"
 
 #include "RooRealVar.h"
 #include "RooAbsDataStore.h"

roofit/roofitcore/src/RooCompositeDataStore.cxx

@@ -44,7 +44,9 @@ When iterated from start to finish, datasets will be traversed in the order of t
 #include "TROOT.h"
 
 #include <iomanip>
-using namespace std ;
+#include <iostream>
+
+using namespace std;
 
 ClassImp(RooCompositeDataStore);
 ;

roofit/roofitcore/src/RooDataProjBinding.cxx

@@ -30,7 +30,6 @@ constructed from all the categories in the dataset
 **/
 
 #include "RooFit.h"
-#include "Riostream.h"
 
 #include "RooDataProjBinding.h"
 #include "RooAbsReal.h"
@@ -41,9 +40,8 @@ constructed from all the categories in the dataset
 #include "RooAbsPdf.h"
 #include "RooMsgService.h"
 
-#include <assert.h>
-
-
+#include <iostream>
+#include <cassert>
 
 using namespace std;
 

roofit/roofitcore/src/RooDataSet.cxx

@@ -50,7 +50,6 @@ For the inverse conversion, see `RooAbsData::convertToVectorStore()`.
 
 #include "RooDataSet.h"
 
-#include "Riostream.h"
 #include "RooPlot.h"
 #include "RooAbsReal.h"
 #include "Roo1DTable.h"
@@ -78,6 +77,7 @@ For the inverse conversion, see `RooAbsData::convertToVectorStore()`.
 #include "TBuffer.h"
 #include "ROOT/RMakeUnique.hxx"
 
+#include <iostream>
 #include <fstream>
 
 

roofit/roofitcore/src/RooFormula.cxx

@@ -62,7 +62,7 @@ Check the tutorial rf506_msgservice.C for details.
 #include "RooMsgService.h"
 #include "ROOT/RMakeUnique.hxx"
 #include "TObjString.h"
-
+#include "TClass.h"
 
 #include <sstream>
 #include <regex>

roofit/roofitcore/src/RooHelpers.cxx

@@ -17,6 +17,8 @@
 #include "RooHelpers.h"
 #include "RooAbsRealLValue.h"
 
+#include "TClass.h"
+
 namespace RooHelpers {
 
 LocalChangeMsgLevel::LocalChangeMsgLevel(RooFit::MsgLevel lvl,

roofit/roofitcore/src/RooRealIntegral.cxx

@@ -28,13 +28,11 @@ The actual analytical integrations (if any) are done in the PDF themselves, the
 integration is performed in the various implementations of the RooAbsIntegrator base class.
 **/
 
+#include "RooRealIntegral.h"
+
 #include "RooFit.h"
 
-#include "TClass.h"
 #include "RooMsgService.h"
-#include "Riostream.h"
-#include "TH1.h"
-#include "RooRealIntegral.h"
 #include "RooArgSet.h"
 #include "RooAbsRealLValue.h"
 #include "RooAbsCategoryLValue.h"
@@ -50,9 +48,13 @@ integration is performed in the various implementations of the RooAbsIntegrator
 #include "RooDouble.h"
 #include "RooTrace.h"
 
+#include "TClass.h"
+
+#include <iostream>
+
 using namespace std;
 
-ClassImp(RooRealIntegral); 
+ClassImp(RooRealIntegral);
 
 
 Int_t RooRealIntegral::_cacheAllNDim(2) ;

roofit/roofitcore/src/RooRealSumFunc.cxx

@@ -38,6 +38,7 @@
 
 #include "TIterator.h"
 #include "TList.h"
+#include "TClass.h"
 #include "RooRealSumFunc.h"
 #include "RooRealProxy.h"
 #include "RooPlot.h"

roofit/roofitcore/src/RooRealSumPdf.cxx

@@ -50,6 +50,7 @@ to the fractions of the various functions. **This requires setting the last argu
 #include "TError.h"
 #include "TIterator.h"
 #include "TList.h"
+#include "TClass.h"
 #include "RooRealSumPdf.h"
 #include "RooRealProxy.h"
 #include "RooPlot.h"

roofit/roofitcore/src/RooSimGenContext.cxx

@@ -31,7 +31,6 @@ that an event originates from a certain category.
 **/
 
 #include "RooFit.h"
-#include "Riostream.h"
 
 #include "RooSimGenContext.h"
 #include "RooSimultaneous.h"
@@ -43,8 +42,9 @@ that an event originates from a certain category.
 #include "RooRandom.h"
 #include "RooGlobalFunc.h"
 
-using namespace RooFit ;
+using namespace RooFit;
 
+#include <iostream>
 #include <string>
 
 using namespace std;

roofit/roofitcore/src/RooSimSplitGenContext.cxx

@@ -25,7 +25,6 @@ component pdfs.
 **/
 
 #include "RooFit.h"
-#include "Riostream.h"
 
 #include "RooSimSplitGenContext.h"
 #include "RooSimultaneous.h"
@@ -37,15 +36,15 @@ component pdfs.
 #include "RooRandom.h"
 #include "RooGlobalFunc.h"
 
-using namespace RooFit ;
+using namespace RooFit;
 
+#include <iostream>
 #include <string>
 
 using namespace std;
 
 ClassImp(RooSimSplitGenContext);
-;
-
+
 
 ////////////////////////////////////////////////////////////////////////////////
 /// Constructor of specialized generator context for RooSimultaneous p.d.f.s. This

roofit/roofitcore/src/RooSimultaneous.cxx

@@ -47,7 +47,6 @@ in each category.
 **/
 
 #include "RooFit.h"
-#include "Riostream.h"
 
 #include "RooSimultaneous.h"
 #include "RooAbsCategoryLValue.h"
@@ -71,11 +70,11 @@ in each category.
 #include "RooArgSet.h"
 #include "RooHelpers.h"
 
-using namespace std ;
+#include <iostream>
 
-ClassImp(RooSimultaneous);
-;
+using namespace std;
 
+ClassImp(RooSimultaneous);
 
 
 

roofit/roofitcore/src/RooTrace.cxx

@@ -34,7 +34,7 @@ each object.
 #include "RooMsgService.h"
 
 #include <iomanip>
-
+#include "TClass.h"
 
 
 using namespace std;

roofit/roofitcore/src/RooVectorDataStore.cxx

@@ -41,6 +41,7 @@ use a TTree as internal storage mechanism
 #include "TDirectory.h"
 #include "TBuffer.h"
 #include "TROOT.h"
+#include "TList.h"
 
 #include <iomanip>
 using namespace std ;