Disable Oracle on OS X to prevent linking errors. #563
Conversation
libOracle.so is compiled with stdc++ and on OS X we're always compiling with libc++. To prevent linking errors between libOracle.so and the generated ROOT code in the STL symbols, we just disable Oracle on this platform.
|
See for example #562 for something that is affected by this. |
| message(WARNING "Oracle not supported when compiling with libc++!") | ||
| set(oracle OFF CACHE BOOL "" FORCE) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
You are assuming that oracle will never deliver libraries for libc++. Can we not at this moment disable the oracle option -Doracle=OFF for the current state of the externals we use.
|
It would be sufficient to disable oracle for this build of ROOT using these set of externals. I would not change the code for this. |
|
Shouldn't we do that in jenkins instead? I.e. This does not check if the oracle library found has been compiled with one library or the other (so once/when there is a oracle library using libcxx this test will be wrong). |
|
Plus (for the record) there are people building ROOT on MacOS with GCC, even successfully so. They could use the default libocci. |
4 participants
libOracle.so is compiled with stdc++ and on OS X we're always
compiling with libc++. To prevent linking errors between libOracle.so
and the generated ROOT code in the STL symbols, we just disable
Oracle on this platform.