Skip to content

Disable Oracle on OS X to prevent linking errors. #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Teemperor wants to merge 1 commit into from
Closed

Disable Oracle on OS X to prevent linking errors. #563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cmake/modules/SearchInstalledSoftware.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,14 @@ if(mysql)
endif()

#---Check for Oracle-------------------------------------------------------------------
# OCCI is compiled with libstdc++ which has a different ABI than libc++.
# So we better turn of Oracle in this situation to prevent linking errors between
# ROOT using libc++ and libOracle.so using libstdc++.
if(oracle AND libcxx)
message(WARNING "Oracle not supported when compiling with libc++!")
set(oracle OFF CACHE BOOL "" FORCE)
endif()

Copy link
Contributor

@peremato peremato May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are assuming that oracle will never deliver libraries for libc++. Can we not at this moment disable the oracle option -Doracle=OFF for the current state of the externals we use.

if(oracle)
message(STATUS "Looking for Oracle")
find_package(Oracle)
Expand Down