Add RConfigure preprocessor flag for pymva and rmva (R__HAS_PYMVA) and (R__HAS_RMVA) #5630
Conversation
|
Starting build on |
|
Build failed on ROOT-performance-centos7-multicore/default. Errors:
Failing tests: |
stwunsch
left a comment
stwunsch
left a comment
There was a problem hiding this comment.
Nice! I think you use the wrong preprocessor variable in the RNN tutorial, please check! Also I would change the commit message of your second commit because it mixes RMVA in the title and PyMVA in the detailed description.
|
|
||
| const char *rnn_type = "RNN"; | ||
|
|
||
| #ifdef R__HAS_RMVA |
There was a problem hiding this comment.
That should by R__HAS_PYMVA, right?
lmoneta
force-pushed
the
add_pymva_preprocessor_flag
branch
from
593e1a2 to
e6119ae
Compare
|
Starting build on |
…d (R__HAS_RMVA) (root-project#5630) * Add preprocessor flag in RConfigure.h for pymva and rmva * Enable RMVA when R is found and tmva is on * Update CNN and RNN tutorial to work also when ROOT is built without Pymva
4 participants
Add R__HAS_PYMVA and R__HAS_RMVA in RConfigure.h
Use it in the CNN and RNN tutorials to be able to run them when pymva is not built.
This PR should replace #5559