Fix for ROOT-8949 - cmake does not rebuild core dictionary when LinkDef1/2/3 changed #852
Conversation
…ef1/2/3.h file is changed
|
Starting build on |
cmake/modules/RootNewMacros.cmake
Outdated
| endif() | ||
| if(TARGET G__${library}) | ||
| add_dependencies(${library} G__${library}) | ||
| message("${library} --> G__${library}") |
There was a problem hiding this comment.
Hi Pere, maybe this line sneaked in?
There was a problem hiding this comment.
Well spotted! Thanks!
|
Starting build on |
|
It works for me, but do we really need such extra file (.stamp)? |
|
@linev The rebuilding is necessary, as all dictionaries depend on the Core one. |
|
@linev Do you care if an extra file is created in the build tree? We do create 3 files for each dictionary, this stamp file summarizes them for what concerns dependencies. |
Not at all - as long as everything works properly. |
|
Sorry for misleading typo in my previous comment. |
4 participants
This is fix for ROOT-8949 following the suggestions from the CMake developers at https://gitlab.kitware.com/cmake/cmake/issues/16830