Skip to content

[cxxmodules] Enable the semantic global module index to boost performance. #5884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vgvassilev wants to merge 8 commits into from
Closed

[cxxmodules] Enable the semantic global module index to boost performance. #5884

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef07ff3
Properly check if environment variable boolean values.
vgvassilev Jun 17, 2020
2149fcf
[cxxmodules] Enable the semantic global module index to boost perform…
vgvassilev Jun 17, 2020
ac2cf5a
Try reduce the visitation
vgvassilev Jul 8, 2020
916be13
Visit deeper again.
vgvassilev Jul 10, 2020
1bd7f12
Allow the first not yet loaded module only.
vgvassilev Jul 9, 2020
6b1c8a6
Operations might trigger deserialization.
vgvassilev Jul 14, 2020
8a70b4e
Load all
vgvassilev Jul 28, 2020
8bc19ca
Try to fix classification
vgvassilev Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Operations might trigger deserialization.
  • Loading branch information
@vgvassilev
vgvassilev committed Aug 7, 2020
commit 6b1c8a69f09d2851561d4a4ac2e778e81eacf187
2 changes: 2 additions & 0 deletions core/metacling/src/TCling.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2916,6 +2916,8 @@ void TCling::InspectMembers(TMemberInspector& insp, const void* obj,
// inspect bases
// TNamed::ShowMembers(R__insp);
unsigned iNBase = 0;
// Iteration over base classes might deserialize.
cling::Interpreter::PushTransactionRAII deserRAII(GetInterpreterImpl());
for (clang::CXXRecordDecl::base_class_const_iterator iBase
= recordDecl->bases_begin(), eBase = recordDecl->bases_end();
iBase != eBase; ++iBase, ++iNBase) {
Expand Down
2 changes: 2 additions & 0 deletions core/metacling/src/TClingDataMemberInfo.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,8 @@ long TClingDataMemberInfo::Property() const
property = TClingDeclInfo::Property(property, qt);
const clang::TagType *tt = qt->getAs<clang::TagType>();
if (tt) {
// tt->getDecl() might deserialize.
cling::Interpreter::PushTransactionRAII RAII(fInterp);
const clang::TagDecl *td = tt->getDecl();
if (td->isClass()) {
property |= kIsClass;
Expand Down