Skip to content

[cxxmodules] Enable the semantic global module index to boost performance. #5884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vgvassilev wants to merge 8 commits into from
Closed

[cxxmodules] Enable the semantic global module index to boost performance. #5884

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef07ff3
Properly check if environment variable boolean values.
vgvassilev Jun 17, 2020
2149fcf
[cxxmodules] Enable the semantic global module index to boost perform…
vgvassilev Jun 17, 2020
ac2cf5a
Try reduce the visitation
vgvassilev Jul 8, 2020
916be13
Visit deeper again.
vgvassilev Jul 10, 2020
1bd7f12
Allow the first not yet loaded module only.
vgvassilev Jul 9, 2020
6b1c8a6
Operations might trigger deserialization.
vgvassilev Jul 14, 2020
8a70b4e
Load all
vgvassilev Jul 28, 2020
8bc19ca
Try to fix classification
vgvassilev Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try reduce the visitation
  • Loading branch information
@vgvassilev
vgvassilev committed Aug 7, 2020
commit ac2cf5aa73eec396c635b8d8c32c2eb25687cdf7
39 changes: 30 additions & 9 deletions core/metacling/src/TCling.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,26 +1113,47 @@ static GlobalModuleIndex *loadGlobalModuleIndex(SourceLocation TriggerLoc, cling
struct DefinitionFinder : public RecursiveASTVisitor<DefinitionFinder> {
DefinitionFinder(clang::GlobalModuleIndex::UserDefinedInterestingIDs& IDs,
clang::TranslationUnitDecl* TU) : DefinitionIDs(IDs) {
TraverseDecl(TU);
}
bool VisitNamedDecl(NamedDecl *ND) {
for (auto R : ND->redecls()) {
if (!R->isFromASTFile())
for (const Decl* D : TU->decls()) {
if (!isa<NamedDecl>(D))
continue;
if (TagDecl *TD = llvm::dyn_cast<TagDecl>(R)) {
const NamedDecl* ND = cast<NamedDecl>(D);
if (!ND->isFromASTFile())
continue;

if (const TagDecl *TD = llvm::dyn_cast<TagDecl>(ND)) {
if (TD->isCompleteDefinition())
Register(TD);
} else if (NamespaceDecl *NSD = llvm::dyn_cast<NamespaceDecl>(R))
} else if (const NamespaceDecl *NSD = llvm::dyn_cast<NamespaceDecl>(ND)) {
// if (!NSD->getParent()->isTranslationUnit())
// return false;
Register(NSD, /*AddSingleEntry=*/ false);
else if (TypedefNameDecl *TND = dyn_cast<TypedefNameDecl>(R))
}
else if (const TypedefNameDecl *TND = dyn_cast<TypedefNameDecl>(ND))
Register(TND);
// FIXME: Add the rest...
}
//TraverseDecl(TU);
}
bool VisitNamedDecl(NamedDecl *ND) {
if (!ND->isFromASTFile())
return true; // Do not descend.

if (TagDecl *TD = llvm::dyn_cast<TagDecl>(ND)) {
if (TD->isCompleteDefinition())
Register(TD);
} else if (NamespaceDecl *NSD = llvm::dyn_cast<NamespaceDecl>(ND)) {
// if (!NSD->getParent()->isTranslationUnit())
// return false;
Register(NSD, /*AddSingleEntry=*/ false);
}
else if (TypedefNameDecl *TND = dyn_cast<TypedefNameDecl>(ND))
Register(TND);
// FIXME: Add the rest...
return true; // continue decending
}
private:
clang::GlobalModuleIndex::UserDefinedInterestingIDs &DefinitionIDs;
void Register(NamedDecl* ND, bool AddSingleEntry = true) {
void Register(const NamedDecl* ND, bool AddSingleEntry = true) {
assert(ND->isFromASTFile());
// FIXME: All decls should have an owning module once rootcling
// updates its generated decls from within the LookupHelper & co.
Expand Down