Skip to content

gROOTMutex -> RWLock #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcanal wants to merge 11 commits into from
Closed

gROOTMutex -> RWLock #596

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b20ec00
Add missing init in TErrorLock and make it public
pcanal Jun 22, 2017
75ff737
Move gROOT initialization to more central place in the threadsafely i…
pcanal Jun 11, 2017
6baaf01
Make TMutex compliant with standard library
pcanal Jun 15, 2017
ded122d
Add TVirtualRWMutex and TRWMutexImp
pcanal May 30, 2017
e3f1995
Remove unused base class (TObject ... )
pcanal May 30, 2017
dc71a44
Add TReentrantRWLock starting from TRWSpinLock
pcanal Jun 14, 2017
1eb2bfe
Set new name (TReentrantRWLock), make template on mutex type and add …
pcanal Jun 14, 2017
fa777ae
Add minimal test and performance test of ReentrantRWLock
pcanal Jun 15, 2017
7114a9b
Allow to select between thread-local or lock+map for 'local' info
pcanal Jun 16, 2017
bcd5ecc
Extent test to include both thread-local or lock+map for 'local' info…
pcanal Jun 21, 2017
b2cfef2
Add reminder to replace write lock with read lock in very used code p…
pcanal Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move gROOT initialization to more central place in the threadsafely i… 
…nitialization
  • Loading branch information
@pcanal
pcanal committed Jun 22, 2017
commit 75ff73730a5380b241080eb54fb679b4729056a6
3 changes: 0 additions & 3 deletions core/base/src/TROOT.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,9 +497,6 @@ namespace Internal {
/// Enables the global mutex to make ROOT thread safe/aware.
void EnableThreadSafety()
{
// 'Insure' gROOT is created before initializing the Thread safe behavior
// (to make sure we do not have two attempting to create it).
GetROOT();
static void (*sym)() = (void(*)())Internal::GetSymInLibImt("ROOT_TThread_Initialize");
if (sym)
sym();
Expand Down
4 changes: 4 additions & 0 deletions core/thread/src/TThread.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,10 @@ void TThread::Init()
::Fatal("Init","_REENTRANT must be #define-d for TThread to work properly.");
#endif

// 'Insure' gROOT is created before initializing the Thread safe behavior
// (to make sure we do not have two attempting to create it).
ROOT::GetROOT();

fgThreadImp = gThreadFactory->CreateThreadImp();
gMainInternalMutex = new TMutex(kTRUE);

Expand Down