Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add reminder to replace write lock with read lock in very used code p…
…ath.

well used for every call to RecursiveRemove
  • Loading branch information
pcanal committed Jun 22, 2017
commit b2cfef2672f568671bceeb4ada24b92e00dba6b2
6 changes: 6 additions & 0 deletions core/metacling/src/TCling.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -2981,6 +2981,12 @@ Bool_t TCling::HandleNewTransaction(const cling::Transaction &T)

void TCling::RecursiveRemove(TObject* obj)
{
// NOTE: When replacing the mutex by a ReadWrite mutex, we **must**
// put in place the Read/Write part here. Keeping the write lock
// here is 'catasptrophic' for scaling as it means that ALL calls
// to RecursiveRemove will take the write lock and performance
// of many threads trying to access the write lock at the same
// time is relatively bad.
R__LOCKGUARD(gInterpreterMutex);
// Note that fgSetOfSpecials is supposed to be updated by TClingCallbacks::tryFindROOTSpecialInternal
// (but isn't at the moment).
Expand Down