Skip to content

Conversation

@vgvassilev
Copy link
Member

No description provided.

@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=ON -Dccache=ON

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

  • include/Rtypes.h:331:82: error: redefinition of ‘int ROOT::{anonymous}::R__dummyintdefault24’
  • include/Rtypes.h:333:42: error: redefinition of ‘class ROOT::{anonymous}::R__dummyintdefault24_c’
  • include/Rtypes.h:333:42: error: previous definition of ‘class ROOT::{anonymous}::R__dummyintdefault24_c’

@phsft-bot
Copy link

Build failed on mac1012/native.
See console output.

Errors:

  • /Volumes/MacintoshHD2/ec/build/workspace/root-pullrequests-build/root/core/base/src/TFileInfo.cxx:24:21: error: redefinition of 'R__dummyintdefault24'
  • /Volumes/MacintoshHD2/ec/build/workspace/root-pullrequests-build/root/core/base/src/TFileInfo.cxx:24:21: error: redefinition of 'R__dummyintdefault24_c'

@phsft-bot
Copy link

Build failed on slc6/gcc49.
See console output.

Errors:

  • include/Rtypes.h:331:82: error: redefinition of ‘int ROOT::{anonymous}::R__dummyintdefault24’
  • include/Rtypes.h:333:42: error: redefinition of ‘class ROOT::{anonymous}::R__dummyintdefault24_c’
  • include/Rtypes.h:333:42: error: previous definition of ‘class ROOT::{anonymous}::R__dummyintdefault24_c’

@phsft-bot
Copy link

Build failed on centos7/gcc49.
See console output.

Errors:

  • include/Rtypes.h:331:82: error: redefinition of ‘int ROOT::{anonymous}::R__dummyintdefault24’
  • include/Rtypes.h:333:42: error: redefinition of ‘class ROOT::{anonymous}::R__dummyintdefault24_c’
  • include/Rtypes.h:333:42: error: previous definition of ‘class ROOT::{anonymous}::R__dummyintdefault24_c’

@phsft-bot
Copy link

Build failed on ubuntu14/native.
See console output.

Errors:

  • /mnt/build/workspace/root-pullrequests-build/root/core/base/src/TVirtualMonitoring.cxx:21:587: error: redefinition of ‘int ROOT::{anonymous}::R__dummyintdefault21’
  • /mnt/build/workspace/root-pullrequests-build/root/core/base/src/TVirtualMonitoring.cxx:21:115: error: ‘int ROOT::{anonymous}::R__dummyintdefault21’ previously declared here
  • /mnt/build/workspace/root-pullrequests-build/root/core/base/src/TVirtualMonitoring.cxx:21:758: error: redefinition of ‘class ROOT::{anonymous}::R__dummyintdefault21_c’
  • /mnt/build/workspace/root-pullrequests-build/root/core/base/src/TVirtualMonitoring.cxx:21:330: error: previous definition of ‘class ROOT::{anonymous}::R__dummyintdefault21_c’

@vgvassilev vgvassilev force-pushed the clang-tidy-use-nullptr branch from 5d175bb to 6752d26 Compare June 5, 2017 20:17
@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=ON -Dccache=ON

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/roofit/roofit/src/RooMomentMorph.cxx:217:69: error: call of overloaded ‘getObj(std::nullptr_t, std::nullptr_t)’ is ambiguous

Warnings:

  • include/TProofDebug.h:57:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  • include/TProofDebug.h:57:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  • include/TProofDebug.h:57:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  • include/TProofDebug.h:57:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  • include/TProofDebug.h:57:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  • include/TProofDebug.h:57:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  • include/TProofDebug.h:57:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  • include/TProofDebug.h:57:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  • include/TProofDebug.h:57:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  • include/TProofDebug.h:57:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]

And 20 more

@phsft-bot
Copy link

Build failed on centos7/gcc49.
See console output.

Errors:

  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/roofit/roofit/src/RooMomentMorph.cxx:217:69: error: call of overloaded ‘getObj(std::nullptr_t, std::nullptr_t)’ is ambiguous

@phsft-bot
Copy link

Build failed on mac1012/native.
See console output.

Errors:

  • /Volumes/MacintoshHD2/build/workspace/root-pullrequests-build/root/graf2d/cocoa/src/ROOTOpenGLView.mm:125:35: error: invalid operands to binary expression ('NSUInteger' (aka 'unsigned long') and 'nullptr_t')
  • clang: error: no such file or directory: 'CMakeFiles/GCocoa.dir/src/ROOTOpenGLView.mm.o'
  • /Volumes/MacintoshHD2/build/workspace/root-pullrequests-build/root/roofit/roofit/src/RooMomentMorph.cxx:217:46: error: call to member function 'getObj' is ambiguous
  • clang: error: no such file or directory: 'CMakeFiles/RooFit.dir/src/RooMomentMorph.cxx.o'

@phsft-bot
Copy link

Build failed on slc6/gcc49.
See console output.

Errors:

  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/roofit/roofit/src/RooMomentMorph.cxx:217:69: error: call of overloaded ‘getObj(std::nullptr_t, std::nullptr_t)’ is ambiguous

@vgvassilev vgvassilev force-pushed the clang-tidy-use-nullptr branch from 6752d26 to ab9c500 Compare June 5, 2017 20:49
@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=ON -Dccache=ON

@phsft-bot
Copy link

Build failed on mac1012/native.
See console output.

Errors:

  • /Volumes/MacintoshHD2/ec/build/workspace/root-pullrequests-build/root/graf2d/cocoa/src/ROOTOpenGLView.mm:125:35: error: invalid operands to binary expression ('NSUInteger' (aka 'unsigned long') and 'nullptr_t')

@vgvassilev vgvassilev force-pushed the clang-tidy-use-nullptr branch from ab9c500 to 6e7c7e1 Compare June 5, 2017 21:47
@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=ON -Dccache=ON

@vgvassilev vgvassilev force-pushed the clang-tidy-use-nullptr branch from 6e7c7e1 to 9ecf3fa Compare June 6, 2017 13:34
@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=ON -Dccache=ON

@vgvassilev vgvassilev force-pushed the clang-tidy-use-nullptr branch from 9ecf3fa to bd2e011 Compare June 19, 2017 21:33
@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Build failed on mac1012/native.
See console output.

Errors:

  • /Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1603:1: error: function definition is not allowed here
  • /Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1637:1: error: function definition is not allowed here
  • /Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1724:1: error: function definition is not allowed here
  • /Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1746:1: error: function definition is not allowed here
  • /Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1756:1: error: function definition is not allowed here
  • /Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1767:1: error: function definition is not allowed here
  • /Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1854:1: error: function definition is not allowed here
  • /Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1871:1: error: function definition is not allowed here
  • /Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1906:1: error: function definition is not allowed here
  • /Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1985:1: error: function definition is not allowed here

And 9 more

Warnings:

@phsft-bot
Copy link

Build failed on ubuntu14/native.
See console output.

Errors:

  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1603:1: error: a function-definition is not allowed here before ‘{’ token
  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:6018:1: error: expected ‘}’ at end of input

Warnings:

  • JENKINS-19022: warning: possible memory leak due to Git plugin usage; see: https://wiki.jenkins-ci.org/display/JENKINS/Remove+Git+Plugin+BuildsByBranch+BuildData
  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:289:14: warning: ‘GLint gl2psPrintPrimitives()’ declared ‘static’ but never defined [-Wunused-function]
  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:345:15: warning: ‘size_t gl2psWriteBigEndian(long unsigned int, size_t)’ defined but not used [-Wunused-function]
  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:438:12: warning: ‘int gl2psPrintf(const char*, ...)’ defined but not used [-Wunused-function]
  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:466:13: warning: ‘void gl2psPrintGzipHeader()’ defined but not used [-Wunused-function]
  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:484:13: warning: ‘void gl2psPrintGzipFooter()’ defined but not used [-Wunused-function]
  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:562:13: warning: ‘void gl2psListReset(GL2PSlist*)’ defined but not used [-Wunused-function]
  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:623:13: warning: ‘void gl2psListActionInverse(GL2PSlist*, void ()(void))’ defined but not used [-Wunused-function]
  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:697:18: warning: ‘GLboolean gl2psVertsSameColor(const GL2PSprimitive*)’ defined but not used [-Wunused-function]
  • /mnt/vdb/lsf/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:709:18: warning: ‘GLboolean gl2psSameColorThreshold(int, GLfloat ()[4], GLfloat)’ defined but not used [-Wunused-function]

And 13 more

@phsft-bot
Copy link

Build failed on centos7/gcc49.
See console output.

Errors:

  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1603:1: error: a function-definition is not allowed here before ‘{’ token
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:6018:1: error: expected ‘}’ at end of input

Warnings:

  • JENKINS-19022: warning: possible memory leak due to Git plugin usage; see: https://wiki.jenkins-ci.org/display/JENKINS/Remove+Git+Plugin+BuildsByBranch+BuildData
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:289:14: warning: ‘GLint gl2psPrintPrimitives()’ declared ‘static’ but never defined [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:345:15: warning: ‘size_t gl2psWriteBigEndian(long unsigned int, size_t)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:438:12: warning: ‘int gl2psPrintf(const char*, ...)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:466:13: warning: ‘void gl2psPrintGzipHeader()’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:484:13: warning: ‘void gl2psPrintGzipFooter()’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:562:13: warning: ‘void gl2psListReset(GL2PSlist*)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:623:13: warning: ‘void gl2psListActionInverse(GL2PSlist*, void ()(void))’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:697:18: warning: ‘GLboolean gl2psVertsSameColor(const GL2PSprimitive*)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:709:18: warning: ‘GLboolean gl2psSameColorThreshold(int, GLfloat ()[4], GLfloat)’ defined but not used [-Wunused-function]

And 13 more

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1603:1: error: a function-definition is not allowed here before ‘{’ token
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:6018:1: error: expected ‘}’ at end of input

Warnings:

  • JENKINS-19022: warning: possible memory leak due to Git plugin usage; see: https://wiki.jenkins-ci.org/display/JENKINS/Remove+Git+Plugin+BuildsByBranch+BuildData
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:289:14: warning: ‘GLint gl2psPrintPrimitives()’ declared ‘static’ but never defined [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1532:18: warning: ‘GLboolean gl2psLess(GLfloat, GLfloat)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1526:18: warning: ‘GLboolean gl2psGreater(GLfloat, GLfloat)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1470:13: warning: ‘void gl2psFreeImagemap(GL2PSimagemap*)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1385:12: warning: ‘int gl2psCompareDepth(const void*, const void*)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1058:18: warning: ‘GLboolean gl2psSamePosition(GLfloat*, GLfloat*)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1021:24: warning: ‘GL2PSprimitive* gl2psCopyPrimitive(GL2PSprimitive*)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1010:13: warning: ‘void gl2psInitTriangle(GL2PStriangle*)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1000:13: warning: ‘void gl2psFillTriangleFromPrimitive(GL2PStriangle*, GL2PSprimitive*, GLboolean)’ defined but not used [-Wunused-function]

And 13 more

@phsft-bot
Copy link

Build failed on slc6/gcc49.
See console output.

Errors:

  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:1603:1: error: a function-definition is not allowed here before ‘{’ token
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:6018:1: error: expected ‘}’ at end of input

Warnings:

  • JENKINS-19022: warning: possible memory leak due to Git plugin usage; see: https://wiki.jenkins-ci.org/display/JENKINS/Remove+Git+Plugin+BuildsByBranch+BuildData
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:289:14: warning: ‘GLint gl2psPrintPrimitives()’ declared ‘static’ but never defined [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:345:15: warning: ‘size_t gl2psWriteBigEndian(long unsigned int, size_t)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:438:12: warning: ‘int gl2psPrintf(const char*, ...)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:466:13: warning: ‘void gl2psPrintGzipHeader()’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:484:13: warning: ‘void gl2psPrintGzipFooter()’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:562:13: warning: ‘void gl2psListReset(GL2PSlist*)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:623:13: warning: ‘void gl2psListActionInverse(GL2PSlist*, void ()(void))’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:697:18: warning: ‘GLboolean gl2psVertsSameColor(const GL2PSprimitive*)’ defined but not used [-Wunused-function]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/graf3d/gl/src/gl2ps.cxx:709:18: warning: ‘GLboolean gl2psSameColorThreshold(int, GLfloat ()[4], GLfloat)’ defined but not used [-Wunused-function]

And 13 more

@amadio
Copy link
Member

amadio commented Jul 25, 2017

Hi @vgvassilev, is this PR still relevant? Has another equivalent thing been merged?

@amadio
Copy link
Member

amadio commented Sep 20, 2017

Ping.

@vgvassilev
Copy link
Member Author

@amadio, I wanted redo it without running clang-format on the changed lines.

@amadio
Copy link
Member

amadio commented Sep 20, 2017

Ok, just wanted to know if this should stay here or be closed... Thanks for the update.

@amadio
Copy link
Member

amadio commented Sep 20, 2017

Given the amount of conflicts, it may actually make sense to just close this pull request and start a new one later.

@vgvassilev
Copy link
Member Author

I'd keep it open.

@bbockelm
Copy link
Contributor

@vgvassilev - is it possible to break up this PR to a series of requests, one per module (or sub-module?)?

Would help prevent the merge conflicts from accumulating...

@vgvassilev
Copy link
Member Author

We want to fix it in one go. I will take care of this as soon as I get a chance ;)

@vgvassilev
Copy link
Member Author

I do not have the bandwidth now for this PR.

@vgvassilev vgvassilev closed this Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants