-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Use nullptr #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nullptr #606
Conversation
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
|
|
Build failed on mac1012/native. Errors:
|
|
Build failed on slc6/gcc49. Errors:
|
|
Build failed on centos7/gcc49. Errors:
|
|
Build failed on ubuntu14/native. Errors:
|
5d175bb to
6752d26
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 20 more |
|
Build failed on centos7/gcc49. Errors:
|
|
Build failed on mac1012/native. Errors:
|
|
Build failed on slc6/gcc49. Errors:
|
6752d26 to
ab9c500
Compare
|
Starting build on |
|
Build failed on mac1012/native. Errors:
|
ab9c500 to
6e7c7e1
Compare
|
Starting build on |
6e7c7e1 to
9ecf3fa
Compare
|
Starting build on |
9ecf3fa to
bd2e011
Compare
|
Starting build on |
|
Build failed on mac1012/native. Errors:
And 9 more Warnings:
|
|
Build failed on ubuntu14/native. Errors:
Warnings:
And 13 more |
|
Build failed on centos7/gcc49. Errors:
Warnings:
And 13 more |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 13 more |
|
Build failed on slc6/gcc49. Errors:
Warnings:
And 13 more |
|
Hi @vgvassilev, is this PR still relevant? Has another equivalent thing been merged? |
|
Ping. |
|
@amadio, I wanted redo it without running clang-format on the changed lines. |
|
Ok, just wanted to know if this should stay here or be closed... Thanks for the update. |
|
Given the amount of conflicts, it may actually make sense to just close this pull request and start a new one later. |
|
I'd keep it open. |
|
@vgvassilev - is it possible to break up this PR to a series of requests, one per module (or sub-module?)? Would help prevent the merge conflicts from accumulating... |
|
We want to fix it in one go. I will take care of this as soon as I get a chance ;) |
|
I do not have the bandwidth now for this PR. |
No description provided.