-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[testing][cxxmodules] Load module in payload instead #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Starting build on |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 4 more Warnings:
And 7 more Failing tests:
And 96 more |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 2 more Warnings:
And 7 more Failing tests:
And 54 more |
8dfee10 to
52021b0
Compare
|
Starting build on |
In clang there are two records of what modules are visible: One VisibleModuleSet is in the preprocessor, one is in the sema. In the current code we only make every core module visible in sema, but no in the preprocessor. This causes that we can load decls from the core modules with that, but we can't load macros from them as they are still invisible in the preprocessor. This patch just also makes the module visible in the preprocessor.
In commit 1847320 we remove the code that undefs I which breaks some tests since we now again export macros from the STL module.
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more Failing tests:
And 56 more |
No description provided.