Skip to content

TMVA various fixes #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmoneta merged 8 commits into from
Jun 7, 2017
Merged

TMVA various fixes #610

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4d9ba3b
Take weights into consideration in text output.
ashlaban Jun 4, 2017
284f1b5
Add doc and explicit multiclass support for Factory:GetROCIntegral
ashlaban Jun 6, 2017
d2714c2
TMVA Multiclass: Disable ranking by effS*purS
ashlaban Jun 6, 2017
485e044
Add output when using event weights with DNN
ashlaban Jun 6, 2017
b6804be
Deprecate DNN arch=STANDARD, early exist check DNN arch=CPU/GPU
ashlaban Jun 6, 2017
2b271c7
clang-format
ashlaban Jun 6, 2017
4540b9f
clang-format
ashlaban Jun 6, 2017
dc66ecc
more clang-format
ashlaban Jun 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add output when using event weights with DNN 
Event weights are not supported by the DNN currently. A patch is
in the works, but for now a message will warn users if they try to
use them with this method.
  • Loading branch information
@ashlaban
ashlaban committed Jun 6, 2017
commit 485e044e24bf62e21d4c57aaec1696e3db68d4b0
10 changes: 10 additions & 0 deletions tmva/tmva/src/MethodDNN.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,16 @@ Bool_t TMVA::MethodDNN::HasAnalysisType(Types::EAnalysisType type,

void TMVA::MethodDNN::Init()
{
// TODO: Remove once weights are considered by the method.
auto & dsi = this->DataInfo();
auto numClasses = dsi.GetNClasses();
for (UInt_t i = 0; i < numClasses; ++i) {
if (dsi.GetWeightExpression(i) != TString("")) {
Log() << kERROR
<< "Currently event weights are not considered properly by this method." << Endl;
Log() << kFATAL << "See above." << Endl;
}
}
}

////////////////////////////////////////////////////////////////////////////////
Expand Down