TMVA various fixes #610
Merged
TMVA various fixes #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation is very exensive so will be disabled for now. The plan is to add this as a configurable option later.
Event weights are not supported by the DNN currently. A patch is in the works, but for now a message will warn users if they try to use them with this method.
Prints deprecation message when trying to instantiate DNN method with architecture STANDARD. Moves printing of existance check for architecture CPU and GPU. If the method cannot be run, a kFATAL warning will be printed at booking time instead of at training time.
|
Can one of the admins verify this patch? |
lmoneta
pushed a commit
that referenced
this pull request
Jun 7, 2017
* Take weights into consideration in text output. * Add doc and explicit multiclass support for Factory:GetROCIntegral * TMVA Multiclass: Disable ranking by effS*purS The calculation is very exensive so will be disabled for now. The plan is to add this as a configurable option later. * Add output when using event weights with DNN Event weights are not supported by the DNN currently. A patch is in the works, but for now a message will warn users if they try to use them with this method. * Deprecate DNN arch=STANDARD, early exist check DNN arch=CPU/GPU Prints deprecation message when trying to instantiate DNN method with architecture STANDARD. Moves printing of existance check for architecture CPU and GPU. If the method cannot be run, a kFATAL warning will be printed at booking time instead of at training time. * clang-format * clang-format * more clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiclass: Better support in Factory methods. Disable costly effS*purS calc.
Classification: Textual output now considers event weights when calc ROC curve.
DNN: Deprecate arch=STANDARD, now fails earlier when using CPU/GPU on unsupported build. Add warning about event weights not being considered.