Resolve warnings reported by -Wnon-virtual-dtor #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a class/struct has virtual method it should also contain a virtual dtor. This is important if one uses allocator (tcmalloc, jemalloc) with C++14 sized deallocation. It's needed to provide a proper object size to deallocation function. We found that jemalloc (dev branch) tends to deadlock if wrong object size is provided to deallocation function. Patch is just as precaution. Signed-off-by: David Abdurachmanov <[email protected]>
|
Can one of the admins verify this patch? |
Member
|
@phsft-bot build |
|
Starting build on |
This was referenced Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a class/struct has virtual method it should also contain a virtual
dtor. This is important if one uses allocator (tcmalloc, jemalloc) with
C++14 sized deallocation. It's needed to provide a proper object size
to deallocation function.
We found that jemalloc (dev branch) tends to deadlock if wrong object
size is provided to deallocation function.
Patch is just as precaution.
Signed-off-by: David Abdurachmanov [email protected]