Merge runtime cxxmodules back to master #637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch also untangles the generation code of PCMs and PCHs. Additionally we enable rootcling warnings during module generation because want them in the future when we try to adjust the working ROOT modulemap to the dictionary layout (i.e. fixing libCore and libThread).
…lure. The sysroot flag should not be set when writing a module otherwise we trigger an assertion in ASTWriter.cpp:1245.
…roject#527) Print a warning when rootcling can't find the ROOT modulemap. So far we only trigger an assertion in LLVM when we can't find the modulemap file which is not very user-friendly. With this patch we actually prints an error message in this situation.
Seems like ignore-non-existent-contents is quite new, so we just remove it for now to avoid crashing on parsing this file with the old clang version inside ROOT.
…ot-project#537) It's AST supposed to depend on NDEBUG, so having this as a module is wrong. And we just remove cassert instead of making it textual to be consistent with the OS X system modulemap.
…ject#538) The modules implementation provides it's own sema source and overwriting this confuses clang when we have -fmodules enabled.
The previous assert was not only ugly but also did the inverse check (failed when it could open the file correctly).
* Don't load the PCH when we have modules enabled. The modules are supposed to provide the same functionality, so for now we don't want the PCH when testing modules. * Disable loading of the rootmap files when running modules. The replacement feature for this is currently not implemented, but we don't want the forward declarations to mix with the declaration loading logic from the modules.
The old code didn't query the modules if the identifier is updated. This caused some checks to fail such as CheckABICompatibility().
|
Starting build on |
|
Build failed on centos7/gcc49. Errors:
Warnings:
|
|
Build failed on slc6/gcc49. Errors:
Warnings:
|
|
Build failed on slc6/gcc62. Errors:
Warnings:
|
|
Build failed on mac1012/native. Errors:
Warnings:
|
vgvassilev
force-pushed
the
runtime-cxxmodules
branch
from
2f8343e to
aaba618
Compare
|
Starting build on |
|
Build failed on ubuntu14/native. Errors:
Warnings:
|
|
Build failed on slc6/gcc49. Errors:
Warnings:
|
|
Build failed on centos7/gcc49. Errors:
Warnings:
|
|
Build failed on slc6/gcc62. Errors:
Warnings:
|
|
Build failed on mac1012/native. Errors:
Warnings:
|
Member
Author
|
Tracked in #638. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done mostly by @Teemperor.