Skip to content

Conversation

@Teemperor
Copy link
Contributor

Currently if we compile this test we get ld warning messages like this:

ld: direct access in function ... to global weak symbol. This was likely
caused by different translation units being compiled with different
visibility settings.

This seems to be caused by the fact that visibility=hidden is spreading
from the parent directory to the test directory, even though it should
only land in the src/ directory. As CMAKE_CXX_FLAGS is working on a
per subdirectory basis, we just move the code for handling the source
code to the src/ folder, which should contain the visibility=hidden.

@Teemperor
Copy link
Contributor Author

Just making a PR to test this on OS X for now.

@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@Axel-Naumann
Copy link
Member

Can you attach the diff -u of the two files? You moving the file and changing it in the same commit makes it impossible for me to figure out what has changed in the content...

@Axel-Naumann
Copy link
Member

The diff was personally brought to my office - it's empty. Will merge once Jenkins reports happiness.

@phsft-bot
Copy link

Build failed on mac1012/native.
See console output.

Warnings:

Failing tests:

Utility commit to make sure git understands we just moved this
file to another place.
@Teemperor Teemperor force-pushed the FixVisibilityInCoreMetacling branch from fe6b391 to 19f6936 Compare June 14, 2017 06:32
@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@Teemperor Teemperor force-pushed the FixVisibilityInCoreMetacling branch 2 times, most recently from 5d824dd to f386162 Compare June 14, 2017 06:33
@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

1 similar comment
@phsft-bot
Copy link

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

The top-level CMakeLists.txt in this packe now only calls down
to the src/ and test/ folder. This should now fully contain
the CMAKE_CXX_FLAGS in the src directory.
@phsft-bot
Copy link

Build failed on mac1012/native.
See console output.

Warnings:

Failing tests:

@phsft-bot
Copy link

Build failed on ubuntu14/native.
See console output.

Warnings:

Failing tests:

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Warnings:

Failing tests:

@phsft-bot
Copy link

Build failed on slc6/gcc49.
See console output.

Warnings:

Failing tests:

@Axel-Naumann
Copy link
Member

The same failure exists without this PR. Merging!

@Axel-Naumann Axel-Naumann merged commit 275e223 into root-project:master Jun 14, 2017
@Teemperor Teemperor deleted the FixVisibilityInCoreMetacling branch December 19, 2017 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants