-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix linking warnings due to visibility=hidden being set for the tests. #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linking warnings due to visibility=hidden being set for the tests. #644
Conversation
|
Just making a PR to test this on OS X for now. |
|
Starting build on |
|
Can you attach the |
|
The diff was personally brought to my office - it's empty. Will merge once Jenkins reports happiness. |
|
Build failed on mac1012/native. Warnings:
Failing tests: |
Utility commit to make sure git understands we just moved this file to another place.
fe6b391 to
19f6936
Compare
|
Starting build on |
5d824dd to
f386162
Compare
|
Starting build on |
1 similar comment
|
Starting build on |
The top-level CMakeLists.txt in this packe now only calls down to the src/ and test/ folder. This should now fully contain the CMAKE_CXX_FLAGS in the src directory.
|
Build failed on mac1012/native. Warnings:
Failing tests: |
|
Build failed on ubuntu14/native. Warnings:
Failing tests: |
|
Build failed on slc6/gcc62. Warnings:
Failing tests: |
|
Build failed on slc6/gcc49. Warnings:
Failing tests: |
|
The same failure exists without this PR. Merging! |
Currently if we compile this test we get ld warning messages like this:
This seems to be caused by the fact that visibility=hidden is spreading
from the parent directory to the test directory, even though it should
only land in the src/ directory. As CMAKE_CXX_FLAGS is working on a
per subdirectory basis, we just move the code for handling the source
code to the src/ folder, which should contain the visibility=hidden.