Added Histogram ROOT File Tutorial #8699

AdvaitDhingra · 2021-07-19T12:20:29Z

This Pull request:

Changes or fixes:

Adds a tutorial demonstrating how a Histogram can be read from a ROOT File. I also added one that demos how a rootfile with a histogram can be made.

Checklist:

tested changes locally
updated the docs (if necessary)

As mentioned in this forum post.

phsft-bot · 2021-07-19T12:20:36Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

Axel-Naumann · 2021-07-19T13:11:18Z

tutorials/hist/ReadROOTFile.C

+
+void ReadROOTFile()
+{
+   TFile *f = new TFile("demo.root");


"hsimple.root" should always exist

Please use a combination of gROOT->GetTutorialsDir() and hsimple.root - which does exist - instead of demo.root - which doesn't exist. You will have to use one of the histograms from hsimple.root then, of course.

The macro https://root.cern/doc/master/h1draw_8C.html does something similar to what you are doing. It creates the file hsimple.root if it does not exist, get the histograms in it and draw them.

tutorials/hist/ReadROOTFile.C

phsft-bot · 2021-07-19T13:21:41Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.python.cpp.roottest_python_cpp_cpp

phsft-bot · 2021-07-20T14:01:59Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-20T14:02:08Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-20T14:28:10Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.tutorial_hist_ReadROOTFile

phsft-bot · 2021-07-20T15:10:04Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.python.cpp.roottest_python_cpp_cpp

Axel-Naumann · 2021-07-20T15:22:27Z

tutorials/hist/ReadROOTFile.C

+
+void ReadROOTFile()
+{
+   TFile *f = new TFile("demo.root");


Please use a combination of gROOT->GetTutorialsDir() and hsimple.root - which does exist - instead of demo.root - which doesn't exist. You will have to use one of the histograms from hsimple.root then, of course.

Axel-Naumann · 2021-07-20T15:23:07Z

tutorials/hist/CreateROOTFile.C

@@ -0,0 +1,31 @@
+/// \file


As we discussed, please remove CreateROOTFile.C but instead rely on hsimple.root which gets created during build time.

phsft-bot · 2021-07-20T16:43:56Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-20T16:44:28Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

ghost · 2021-07-20T16:47:33Z

Congratulations 🎉. DeepCode analyzed your code in 3.946 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

phsft-bot · 2021-07-20T17:10:02Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.tutorial_hist_ReadROOTFile

phsft-bot · 2021-07-20T17:22:58Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-20T16:45:27.072Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

Failing tests:

projectroot.roottest.python.cpp.roottest_python_cpp_cpp

AdvaitDhingra · 2021-07-20T18:00:16Z

I think the problem is that hsimple.root doesnt exist without hsimple.C being run first.

I aborted the jenkins.

Axel-Naumann · 2021-07-21T07:32:02Z

It gets created as part of the build: it does exist, in the tutorials/ subdir of the builddir. As I said, gROOT->GetTutoriaalDir() should help.

AdvaitDhingra · 2021-07-21T09:18:31Z

It gets created as part of the build: it does exist, in the tutorials/ subdir of the builddir. As I said, gROOT->GetTutoriaalDir() should help.

Ahh, ok

phsft-bot · 2021-07-21T13:20:43Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-21T13:22:47Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

AdvaitDhingra · 2021-07-21T13:23:32Z

@Axel-Naumann, @couet pointed out that my read file was basically a simpler version of h1draw.C and that it would be better to just clarify some things in that file.

phsft-bot · 2021-07-21T20:36:36Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-21T21:00:24Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-21T20:49:31.865Z] 904/2183 Test [Math] GSLMultiRootFinder: Fix return pointer to local address #613: tutorial-hist-h1ReadAndDraw .......................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.47 sec

Failing tests:

projectroot.runtutorials.tutorial_hist_h1ReadAndDraw

phsft-bot · 2021-07-21T21:15:01Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-21T20:37:37.519Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

Failing tests:

projectroot.roottest.python.cpp.roottest_python_cpp_cpp

phsft-bot · 2021-07-21T21:50:23Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-21T21:12:31.324Z] 758/2263 Test Fix linking warnings due to visibility=hidden being set for the tests. #644: tutorial-hist-h1ReadAndDraw .......................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.58 sec

Failing tests:

projectroot.runtutorials.tutorial_hist_h1ReadAndDraw

phsft-bot · 2021-07-22T11:41:55Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

AdvaitDhingra · 2021-07-22T11:42:13Z

That was a pretty funny mistake 😆

phsft-bot · 2021-07-22T13:48:30Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.python.cpp.roottest_python_cpp_cpp

Axel-Naumann · 2021-07-23T15:25:04Z

The filename is referred to here:

tutorials/CMakeLists.txt:                       tutorial-hist-h1draw
tutorials/CMakeLists.txt:  set(pyroot-h1draw-depends tutorial-pyroot-hsimple-py)
tutorials/CMakeLists.txt:                                tutorial-pyroot-h1draw-py
tutorials/demos.C:   bar->AddButton("h1draw",     ".x hist/h1draw.C",        "Drawing Options for 1D Histograms");
tutorials/legacy/benchmarks.C:   summary->AddText("  hist/h1draw.C");
tutorials/legacy/benchmarks.C:   bexec(dir,"hist/h1draw.C");
tutorials/legacy/pyroot/benchmarks.py:   'fillrandom.py','fit1.py', 'h1draw.py', 'graph.py',
tutorials/pyroot/demo.py:bar.AddButton( 'h1draw',        r'TPython::Exec( "' + to_run.format('h1draw.py') + '" );',    'Drawing Options for 1D Histograms' )

phsft-bot · 2021-07-26T12:51:06Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

I clarified some things. Modified tutorial Removed my file and modified h1draw.C Minor changes Fixed mistake Simplified

phsft-bot · 2021-07-26T12:52:06Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-26T12:59:32Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-26T14:52:21Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-26T14:14:31.127Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

Failing tests:

projectroot.roottest.python.cpp.roottest_python_cpp_cpp

AdvaitDhingra · 2021-07-28T18:51:44Z

@Axel-Naumann is everything okay?

phsft-bot · 2021-07-29T08:06:11Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-29T09:04:44Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.python.cpp.roottest_python_cpp_cpp

AdvaitDhingra · 2021-07-29T12:05:53Z

Should be fine now

AdvaitDhingra · 2021-08-22T11:19:08Z

@Axel-Naumann @couet everything ok with this?

couet · 2021-07-20T15:31:08Z

tutorials/hist/ReadROOTFile.C

+
+void ReadROOTFile()
+{
+   TFile *f = new TFile("demo.root");


The macro https://root.cern/doc/master/h1draw_8C.html does something similar to what you are doing. It creates the file hsimple.root if it does not exist, get the histograms in it and draw them.

couet · 2021-07-22T13:10:48Z

tutorials/hist/h1ReadAndDraw.C

 #include "TInterpreter.h"

-void h1draw()
+void h1ReadAndDraw()


Be careful changing the macro name. It is used in several places:

% git grep h1draw documentation/doxygen/parallelNotebooks.py: dependenciesgraph.add("pyroot/h1draw.py",["pyroot/hsimple.py"]) documentation/users-guide/Graphics.md:root[] .x tutorials/hist/h1draw.C graf2d/gpad/src/TControlBar.cxx: bar.AddButton("h1draw", ".x h1draw.C", hist/histpainter/doc/index.md: - h1draw.C: Drawing Options for 1D Histograms. test/stressGUI.cxx: bar->AddButton("h1draw", ".x hist/h1draw.C", "Drawing Options for 1D Histograms"); tutorials/CMakeLists.txt: tutorial-hist-h1draw tutorials/CMakeLists.txt: set(pyroot-h1draw-depends tutorial-pyroot-hsimple-py) tutorials/CMakeLists.txt: tutorial-pyroot-h1draw-py tutorials/demos.C: bar->AddButton("h1draw", ".x hist/h1draw.C", "Drawing Options for 1D Histograms"); tutorials/hist/h1draw.C:void h1draw() tutorials/legacy/benchmarks.C: summary->AddText(" hist/h1draw.C"); tutorials/legacy/benchmarks.C: bexec(dir,"hist/h1draw.C"); tutorials/legacy/pyroot/benchmarks.py: 'fillrandom.py','fit1.py', 'h1draw.py', 'graph.py', tutorials/pyroot/demo.py:bar.AddButton( 'h1draw', r'TPython::Exec( "' + to_run.format('h1draw.py') + '" );', 'Drawing Options for 1D Histograms' )

couet · 2021-07-26T14:45:53Z

tutorials/legacy/pyroot/benchmarks.py

 macros = [
   'framework.py', 'hsimple.py', 'hsum.py', 'formula1.py',
-   'fillrandom.py','fit1.py', 'h1draw.py', 'graph.py',
+   'fillrandom.py','fit1.py', 'h1ReadAndDraw.py', 'graph.py',


have you renamed ./tutorials/pyroot/h1draw.py ? it do not see this file renaming in that PR (I may have missed it)

couet · 2021-08-23T07:01:47Z

tutorials/hist/h1ReadAndDraw.C

-   if (gBenchmark->GetBench("hsimple") < 0) gInterpreter->LoadMacro(dir.Data());
-   TFile *example = (TFile*)gROOT->ProcessLineFast("hsimple(1)");
-   if (!example) return;
+   // Generate the ROOT File


Now the comment should not be "generate the ROOT file" as you assume the file already exists. It is not generated.

@AdvaitDhingra can you change the comment ?

phsft-bot · 2021-08-25T16:20:42Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-08-25T16:46:24Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-08-25T16:46:23.582Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1045 (message):

* Modified h1draw.C tutorial I clarified some things. Modified tutorial Removed my file and modified h1draw.C Minor changes Fixed mistake Simplified * Changed name * Renamed pyroot file * Update h1ReadAndDraw.C

AdvaitDhingra requested a review from couet as a code owner July 19, 2021 12:20

AdvaitDhingra changed the title ~~Added HIstogram ROOT File Tutorial~~ Added Histogram ROOT File Tutorial Jul 19, 2021

AdvaitDhingra added in:Graphics improvement in:Documentation labels Jul 19, 2021

jalopezg-git assigned couet Jul 19, 2021

Axel-Naumann reviewed Jul 19, 2021

View reviewed changes

tutorials/hist/ReadROOTFile.C Outdated Show resolved Hide resolved

Axel-Naumann reviewed Jul 19, 2021

View reviewed changes

tutorials/hist/ReadROOTFile.C Outdated Show resolved Hide resolved

Axel-Naumann reviewed Jul 19, 2021

View reviewed changes

tutorials/hist/ReadROOTFile.C Outdated Show resolved Hide resolved

Axel-Naumann requested changes Jul 20, 2021

View reviewed changes

AdvaitDhingra force-pushed the file branch from 605a56c to 5acfa2e Compare July 20, 2021 16:44

AdvaitDhingra force-pushed the file branch from 994600a to 44d47a0 Compare July 21, 2021 13:22

Modified h1draw.C tutorial

ea931c4

I clarified some things. Modified tutorial Removed my file and modified h1draw.C Minor changes Fixed mistake Simplified

AdvaitDhingra force-pushed the file branch from 3b6093f to ea931c4 Compare July 26, 2021 12:51

Changed name

383a216

AdvaitDhingra requested a review from bellenot as a code owner July 26, 2021 12:59

Renamed pyroot file

a6fbcdb

Axel-Naumann approved these changes Aug 25, 2021

View reviewed changes

couet reviewed Aug 25, 2021

View reviewed changes

Update h1ReadAndDraw.C

15bb785

couet merged commit 4f5928c into root-project:master Aug 25, 2021

AdvaitDhingra deleted the file branch August 25, 2021 16:32

Added Histogram ROOT File Tutorial #8699

Added Histogram ROOT File Tutorial #8699

Uh oh!

Conversation

AdvaitDhingra commented Jul 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This Pull request:

Changes or fixes:

Checklist:

Uh oh!

phsft-bot commented Jul 19, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phsft-bot commented Jul 19, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 20, 2021

Uh oh!

phsft-bot commented Jul 20, 2021

Uh oh!

phsft-bot commented Jul 20, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 20, 2021

Failing tests:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Jul 20, 2021

Uh oh!

phsft-bot commented Jul 20, 2021

Uh oh!

ghost commented Jul 20, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

Uh oh!

phsft-bot commented Jul 20, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 20, 2021

Errors:

Failing tests:

Uh oh!

AdvaitDhingra commented Jul 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Axel-Naumann commented Jul 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AdvaitDhingra commented Jul 21, 2021

Uh oh!

phsft-bot commented Jul 21, 2021

Uh oh!

phsft-bot commented Jul 21, 2021

Uh oh!

AdvaitDhingra commented Jul 21, 2021

Uh oh!

phsft-bot commented Jul 21, 2021

Uh oh!

phsft-bot commented Jul 21, 2021

Errors:

Failing tests:

Uh oh!

phsft-bot commented Jul 21, 2021

Errors:

Failing tests:

Uh oh!

AdvaitDhingra commented Jul 19, 2021 •

edited

Loading

ghost commented Jul 20, 2021 •

edited by ghost

Loading

AdvaitDhingra commented Jul 20, 2021 •

edited

Loading

Axel-Naumann commented Jul 21, 2021 •

edited

Loading