Make cling build again on Windows (following the recent changes). To … #653
Conversation
|
Starting build on |
| void deregisterEHFrames() override { | ||
| #ifdef LLVM_ON_WIN32 | ||
| platform::DeRegisterEHFrames(Addr, Size); | ||
| // platform::DeRegisterEHFrames(Addr, Size); |
There was a problem hiding this comment.
@marsupial, should I bring back the arguments of deregisterEHFrames or we could update platform::DeRegisterEHFrames's signature?
There was a problem hiding this comment.
I'm not sure what this is doing.
If exception handling on X64 broke because of the LLVM upgrade it should be fixed.
If exception handling on X86 still isn't implemented, disabling for X64 doesn't seem like a solution.
There was a problem hiding this comment.
@vgvassilev I don't understand the asymmetry between registerEHFrames and deregisterEHFrames. MemoryManager has args to both, RuntimeDyld has args to none, we have args to one and call it override? Could you have a look, please?
There was a problem hiding this comment.
I believe RTDyldMemoryManager has args to a static helper function (for Unix) that the instance method (which is without args call too).
I've pushed the relevant changes for Win64 exceptions here: root-project/cling#164, and hid the code behind a CLING_WIN_SEH_EXCEPTIONS macro until you are ready to turn it on.
5 participants
…be reviewed