Fix issue #6670. Avoid infinite recursion from TClass::InheritsFrom. #6680

pcanal · 2020-10-20T21:11:41Z

Do not inadvertently request TClass::fProperty's initialization during TProtoClass::FillTClass,
the former ends up calling TProtoClass::FillTClass thus leading to an infinite recursion.

phsft-bot · 2020-10-20T21:11:52Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

jblomer · 2020-10-21T07:46:08Z

core/meta/src/TProtoClass.cxx

         return kFALSE;
      }
-      if (cl->Property() & kIsNamespace) {
+      if (cl->fProperty != (-1) && cl->fProperty & kIsNamespace) {


Except for the EProperty values and 0 and -1, is there any other value fProperty could have? I assume -1 == error in contrast to 0 == unknown? This information would be useful to have as as a member documentation for fProperty.

0 isn't a thing for fProperty, and isn't tested for in the original code or Philippe's modification. fProperty & kIsWhatever checks whether the class is a whatever. -1 is the default value of fProperty, stating "we have not determined the class's properties yet" (i.e. Property() has not been called yet)

-1 means unset. 0 would means all properties was found to be 'false'.
Yes, I need to update the documentation :)

Axel-Naumann · 2020-10-21T09:31:18Z

core/meta/src/TProtoClass.cxx

         return kFALSE;
      }
-      if (cl->Property() & kIsNamespace) {
+      if (cl->fProperty != (-1) && cl->fProperty & kIsNamespace) {


Suggested change

if (cl->fProperty != (-1) && cl->fProperty & kIsNamespace) {

if (cl->fProperty != -1 && (cl->fProperty & kIsNamespace)) {

…heritsFrom. Do not inadvertently request TClass::fProperty's initialization during TProtoClass::FillTClass, the former ends up calling TProtoClass::FillTClass thus leading to an infinite recursion.

phsft-bot · 2020-10-21T16:05:19Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-10-21T16:06:58Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

Axel-Naumann · 2020-10-21T16:13:20Z

core/meta/src/TClass.cxx

 ////////////////////////////////////////////////////////////////////////////////
-/// Set TObject::fBits and fStreamerType to cache information about the
-/// class.  The bits are
+/// Returns the properties of the TClass a bit field stored as a `Long_t` value.


Suggested change

/// Returns the properties of the TClass a bit field stored as a `Long_t` value.

/// Returns the properties of the TClass as a bit field stored as a `Long_t` value.

phsft-bot · 2020-10-21T16:24:43Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-10-21T17:05:25Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-21T19:48:30Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-10-21T20:03:48Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-21T20:10:24Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-21T20:10:30Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-26T20:48:41Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-10-26T20:50:36Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2020-10-26T20:50:35.300Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:1616 (message):
[2020-10-26T20:50:35.300Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1065 (message):

phsft-bot · 2020-10-26T21:04:18Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-26T21:10:24Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-26T21:11:18Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-26T21:20:41Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-26T21:28:05Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.evolution.roottest_root_meta_evolution_execCheckSum

…for a file name match (eg. defined_in)

phsft-bot · 2020-10-26T21:40:20Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-10-26T21:42:30Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2020-10-26T21:42:29.611Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:1616 (message):
[2020-10-26T21:42:29.611Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1065 (message):

phsft-bot · 2020-10-26T22:01:41Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.tclass.roottest_root_meta_tclass_execInitOrder

phsft-bot · 2020-10-26T22:12:23Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.tclass.roottest_root_meta_tclass_execInitOrder

pcanal · 2020-10-27T15:35:19Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2020-10-27T15:35:26Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14 with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2020-10-27T15:36:37Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2020-10-27T15:36:36.149Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:1616 (message):
[2020-10-27T15:36:36.149Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

phsft-bot · 2020-10-27T16:40:52Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-3.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.tclass.roottest_root_meta_tclass_execInitOrder

phsft-bot · 2020-10-27T16:49:07Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2020-10-27T16:16:36.347Z] 1046/2152 Test WIP: Reduce scope of interpreter lock in TClass::GetListOfBases() #957: tutorial-v7-ntuple-ntpl003_lhcbOpenData ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.58 sec

Failing tests:

phsft-bot · 2020-10-27T17:08:05Z

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.tclass.roottest_root_meta_tclass_execInitOrder

phsft-bot · 2020-10-27T17:11:01Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2020-10-27T17:04:59.285Z] 798/927 Test Avoid using the interpreter from TDataMember if possible. #807: tutorial-v7-ntuple-ntpl003_lhcbOpenData .............................***Failed Error regular expression found in output. Regex=[: error:] 14.02 sec
[2020-10-27T17:05:40.718Z] Test Avoid using the interpreter from TDataMember if possible. #807: tutorial-v7-ntuple-ntpl003_lhcbOpenData .............................***Failed Error regular expression found in output. Regex=[: error:] 41.57 sec
[2020-10-27T17:05:50.242Z] Test Avoid using the interpreter from TDataMember if possible. #807: tutorial-v7-ntuple-ntpl003_lhcbOpenData .............................***Failed Error regular expression found in output. Regex=[: error:] 9.68 sec

Failing tests:

phsft-bot · 2020-10-27T19:32:28Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2020-10-27T18:20:39.276Z] 950/1958 Test Update to VecCore integration in ROOT #851: tutorial-v7-ntuple-ntpl003_lhcbOpenData ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 4.49 sec

Failing tests:

pcanal · 2020-10-27T19:53:20Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2020-10-27T19:53:29Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14 with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2020-10-27T20:30:08Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Errors:

[2020-10-27T20:09:03.382Z] 1054/2157 Test Partial revert of "Fix nullptr dereference bug in TList::RecursiveRem… #961: tutorial-v7-ntuple-ntpl003_lhcbOpenData ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.68 sec

Failing tests:

projectroot.runtutorials.tutorial_v7_ntuple_ntpl003_lhcbOpenData

phsft-bot · 2020-10-27T20:33:30Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2020-10-27T20:07:27.152Z] 1053/2152 Test WIP: Reduce scope of interpreter lock in TClass::GetListOfBases() #957: tutorial-v7-ntuple-ntpl003_lhcbOpenData ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.57 sec

Failing tests:

projectroot.runtutorials.tutorial_v7_ntuple_ntpl003_lhcbOpenData

phsft-bot · 2020-10-27T20:51:39Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2020-10-27T20:47:10.512Z] 800/927 Test Avoid using the interpreter from TDataMember if possible. #807: tutorial-v7-ntuple-ntpl003_lhcbOpenData .............................***Failed Error regular expression found in output. Regex=[: error:] 4.56 sec
[2020-10-27T20:47:15.952Z] Test Avoid using the interpreter from TDataMember if possible. #807: tutorial-v7-ntuple-ntpl003_lhcbOpenData .............................***Failed Error regular expression found in output. Regex=[: error:] 5.41 sec
[2020-10-27T20:47:21.002Z] Test Avoid using the interpreter from TDataMember if possible. #807: tutorial-v7-ntuple-ntpl003_lhcbOpenData .............................***Failed Error regular expression found in output. Regex=[: error:] 5.15 sec

Failing tests:

projectroot.runtutorials.tutorial_v7_ntuple_ntpl003_lhcbOpenData

phsft-bot · 2020-10-27T21:05:26Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2020-10-27T20:42:01.910Z] 1123/1960 Test Fix for ROOT-8949 - cmake does not rebuild core dictionary when LinkDef1/2/3 changed #852: tutorial-v7-ntuple-ntpl003_lhcbOpenData ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.38 sec

Failing tests:

projectroot.runtutorials.tutorial_v7_ntuple_ntpl003_lhcbOpenData

pcanal · 2020-10-29T18:32:22Z

The failures are unrelated.

pcanal requested a review from jblomer October 20, 2020 21:11

pcanal requested a review from Axel-Naumann October 20, 2020 21:11

pcanal self-assigned this Oct 20, 2020

pcanal added affects:6.18 affects:6.20 affects:6.22 affects:master bug in:Core Libraries labels Oct 20, 2020

pcanal linked an issue Oct 20, 2020 that may be closed by this pull request

segfault in TClass::InheritsFrom() depending on linking order #6670

Closed

pcanal mentioned this pull request Oct 21, 2020

segfault in TClass::InheritsFrom() depending on linking order #6670

Closed

jblomer requested changes Oct 21, 2020

View reviewed changes

Axel-Naumann reviewed Oct 21, 2020

View reviewed changes

Fix issue root-project#6670. Avoid infinite recursion from TClass::In…

b17a9fe

…heritsFrom. Do not inadvertently request TClass::fProperty's initialization during TProtoClass::FillTClass, the former ends up calling TProtoClass::FillTClass thus leading to an infinite recursion.

pcanal force-pushed the Issue-6670 branch from af52062 to 5682ae8 Compare October 21, 2020 16:05

pcanal force-pushed the Issue-6670 branch from 5682ae8 to 9623134 Compare October 21, 2020 16:06

pcanal requested review from Axel-Naumann and jblomer October 21, 2020 16:07

Axel-Naumann approved these changes Oct 21, 2020

View reviewed changes

Extent TClass's fProperty and Property()'s documentation.

7c9fe16

pcanal force-pushed the Issue-6670 branch from 9623134 to 7c9fe16 Compare October 21, 2020 16:24

Don't generate a dictionary for the class underlying a typedef found …

3816aa7

…for a file name match (eg. defined_in)

pcanal merged commit c0cc38a into root-project:master Oct 29, 2020

pcanal deleted the Issue-6670 branch October 29, 2020 18:32

pcanal mentioned this pull request Oct 29, 2020

v6-22: Fix issue #6670. Avoid infinite recursion from TClass::InheritsFrom. #6732

Merged

	if (cl->fProperty != (-1) && cl->fProperty & kIsNamespace) {
	if (cl->fProperty != -1 && (cl->fProperty & kIsNamespace)) {

	/// Returns the properties of the TClass a bit field stored as a `Long_t` value.
	/// Returns the properties of the TClass as a bit field stored as a `Long_t` value.

Fix issue #6670. Avoid infinite recursion from TClass::InheritsFrom. #6680

Fix issue #6670. Avoid infinite recursion from TClass::InheritsFrom. #6680

Uh oh!

Conversation

pcanal commented Oct 20, 2020

Uh oh!

phsft-bot commented Oct 20, 2020

Uh oh!

jblomer Oct 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Axel-Naumann Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

pcanal Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

Axel-Naumann Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Oct 21, 2020

Uh oh!

phsft-bot commented Oct 21, 2020

Uh oh!

Axel-Naumann Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Oct 21, 2020

Uh oh!

phsft-bot commented Oct 21, 2020

Failing tests:

Uh oh!

phsft-bot commented Oct 21, 2020

Uh oh!

phsft-bot commented Oct 21, 2020

Failing tests:

Uh oh!

phsft-bot commented Oct 21, 2020

Failing tests:

Uh oh!

phsft-bot commented Oct 21, 2020

Failing tests:

Uh oh!

phsft-bot commented Oct 26, 2020

Uh oh!

phsft-bot commented Oct 26, 2020

Errors:

Uh oh!

phsft-bot commented Oct 26, 2020

Failing tests:

Uh oh!

phsft-bot commented Oct 26, 2020

Failing tests:

Uh oh!

phsft-bot commented Oct 26, 2020

Failing tests:

Uh oh!

phsft-bot commented Oct 26, 2020

Failing tests:

Uh oh!

phsft-bot commented Oct 26, 2020

Failing tests:

Uh oh!

phsft-bot commented Oct 26, 2020

Uh oh!

phsft-bot commented Oct 26, 2020

Errors:

Uh oh!

phsft-bot commented Oct 26, 2020

Failing tests:

Uh oh!

phsft-bot commented Oct 26, 2020

Failing tests:

Uh oh!

pcanal commented Oct 27, 2020

Uh oh!

phsft-bot commented Oct 27, 2020

Uh oh!

phsft-bot commented Oct 27, 2020

jblomer Oct 21, 2020 •

edited

Loading