[TDF] Consistent, unified selection of column names in TDF #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SelectColumns chooses between the optional user-provided set of column names and the default set. Throws in case of error. Picks an incremental number of column names from the default set until the required number is reached, instead of requiring that the number of default branches is strictly equal to the number of required branches for the transformation/action.
Now unused
|
Starting build on |
Member
|
Very nice upgrade of the code. This paves the way for a robust and flexible way of using data sources different from ROOT trees. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All actions and transformations now use the same method to decide what columns to act no:
ROOT::Internal::TDF::SelectColumnNames. The method picks the necessary number of default columns if the user-provided list is absent. Throws in case of error.The two separate old mechanisms to achieve the same (
PickBranchNamesandGetBranchNames+GetDefaultBranchNames) have been completely removed.This PR does not introduce conflicts with #764, also related to TDF.