Skip to content

Conversation

@amadio
Copy link
Member

@amadio amadio commented Jul 21, 2017

No description provided.

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@amadio amadio changed the title Warning fixes and minor change to clang-format settings to avoid if and body on the same line Change clang-format settings to avoid if statement and its body on the same line Jul 21, 2017
@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@vgvassilev
Copy link
Member

Thanks for doing this. IIRC, that change was planned by @Axel-Naumann.

This is aesthetically bad, and makes it hard to set break points to
specific parts of the code when debugging.
@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@amadio
Copy link
Member Author

amadio commented Jul 21, 2017

@vgvassilev Yes, I remember that. Unfortunately, it was never merged and I cannot find the PR to merge it either, so I created a new one.

@phsft-bot
Copy link

Build failed on ubuntu14/native.
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on mac1012/native.
See console output.

Failing tests:

@vgvassilev vgvassilev merged commit 00ee06d into root-project:master Jul 21, 2017
@amadio
Copy link
Member Author

amadio commented Jul 24, 2017

@vgvassilev I meant to have a discussion before merging this, but oh well... Let's just hope no one complains. Please ask me before merging in the future. My commit message had a small typo that I intended to fix prior to merging, but I didn't push to avoid triggering an extra build just for that.

@vgvassilev
Copy link
Member

@amadio, it seems that we already had that discussion. We had consensus about that and it was a matter of who does it (Please see Axel's email). Don't worry about the typo, it is not a precedent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants