-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Change clang-format settings to avoid if statement and its body on the same line #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Starting build on |
|
Starting build on |
|
Thanks for doing this. IIRC, that change was planned by @Axel-Naumann. |
This is aesthetically bad, and makes it hard to set break points to specific parts of the code when debugging.
|
Starting build on |
|
@vgvassilev Yes, I remember that. Unfortunately, it was never merged and I cannot find the PR to merge it either, so I created a new one. |
|
Build failed on ubuntu14/native. Failing tests: |
|
Build failed on mac1012/native. Failing tests: |
|
@vgvassilev I meant to have a discussion before merging this, but oh well... Let's just hope no one complains. Please ask me before merging in the future. My commit message had a small typo that I intended to fix prior to merging, but I didn't push to avoid triggering an extra build just for that. |
|
@amadio, it seems that we already had that discussion. We had consensus about that and it was a matter of who does it (Please see Axel's email). Don't worry about the typo, it is not a precedent. |
No description provided.