Fix calling variadic functions through TClingCallFunc (Fixes roottest-python-cling-cling on ICC). #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
Member
|
@Teemperor Nice work. I assigned to Pere as he mentioned that he was looking at this before. |
vgvassilev
reviewed
Jul 26, 2017
| TEST(TClingCallFunc, FunctionWrapperVariadic) | ||
| { | ||
| gInterpreter->Declare(R"cpp( | ||
| void FunctionWrapperFuncVariadic(int j, ...) {} |
Member
There was a problem hiding this comment.
Can we actually add some work to the function body, run it and check the result? This would give us one extra degree of certainty.
amadio
reviewed
Jul 26, 2017
| callbuf << arg_type; | ||
| } | ||
| if (FD->isVariadic()) | ||
| callbuf << ", ..."; |
Member
There was a problem hiding this comment.
Clang-format says you didn't use 3 spaces on the line above. 😃
|
Build failed on centos7/gcc49. Errors:
Warnings:
|
Teemperor
force-pushed
the
FixRootClingOnVariadicArguments
branch
from
a77fb8b to
5860dbc
Compare
|
Starting build on |
The casting of the function to improve lookup didn't took variadic functions into aspect, causing ABI issues when generating the code for calling this function. This correctly appends the annotation for a variadic function to the function type. This fixes the roottest-python-cling-cling test when compiling with icc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The casting of the function to improve lookup didn't took
variadic functions into aspect, causing ABI issues when generating
the code for calling this function. This correctly appends the
annotation for a variadic function to the function type.
This fixes the roottest-python-cling-cling test when compiling
with icc.