[TDF] Avoid virtual calls in non-jitted transformations #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking interface change: Filter now returns templated TInterface<TFilter<F,P>> objects instead of TInterface<TFilterBase> as before (and anagolously for Define and Range). Jitted transformations still return TInterfaces wrapping the base classes (e.g. TFilterBase). Filter, Define and Range returned TInterfaces wrapping pointers to the base classes representing the corresponding nodes. This choice was made to limit compile time and ease the introduction of jitted transformations. As a consequence, nodes of the functional graph communicated with each other through virtual calls. This commit lets nodes call into each other through the derived (template) types instead. Given that all nodes' virtual methods are marked `final`, this should allow compilers to de-virtualize such calls.
|
Starting build on |
|
Build failed on centos7/gcc49. Failing tests: |
|
Build failed on ubuntu14/native. Failing tests: |
|
Build failed on mac1012/native. Failing tests: |
|
Build failed on slc6/gcc62. Failing tests: |
|
Build failed on slc6/gcc49. Failing tests: |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking interface change: Filter now returns templated
TInterface<TFilter<F,P>> objects instead of TInterface
as before (and anagolously for Define and Range).
Jitted transformations still return TInterfaces wrapping the base
classes (e.g. TFilterBase).
Filter, Define and Range returned TInterfaces wrapping pointers to the
base classes representing the corresponding nodes. This choice was made
to limit compile time and ease the introduction of jitted transformations.
As a consequence, nodes of the functional graph communicated with each
other through virtual calls.
This commit lets nodes call into each other through the derived (template)
types instead. Given that all nodes' virtual methods are marked
final,this should allow compilers to de-virtualize such calls.
Because of the interface change this commit is expected to break
test_templateRecursionLimit. A PR toroot-project/roottestwill deal with this issue (here).