Skip to content

Conversation

@rahulgrit
Copy link
Contributor

This Pull request:

WIP will fill this shortly

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR is to address #9845

@phsft-bot
Copy link

Can one of the admins verify this patch?

@lmoneta
Copy link
Member

lmoneta commented Feb 17, 2022

@phsft-bot build

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-02-17T11:27:18.348Z] 1147/2251 Test T Color tracking #868: tutorial-roofit-rf711_lagrangianmorph .............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.59 sec
  • [2022-02-17T11:27:18.348Z] 1148/2251 Test [TDF] Avoid virtual calls in non-jitted transformations #869: tutorial-roofit-rf712_lagrangianmorphfit ..........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.47 sec

Failing tests:

@phsft-bot
Copy link

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-02-17T12:30:58.402Z] 1015/2354 Test Simplify implementation of TClass::FindClassOrBaseMethodWithId() #908: tutorial-roofit-rf711_lagrangianmorph .............................................................***Failed Error regular expression found in output. Regex=[: error:] 0.99 sec
  • [2022-02-17T12:30:58.402Z] 1016/2354 Test Miscellaneous warning fixes #909: tutorial-roofit-rf712_lagrangianmorphfit ..........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.99 sec

Failing tests:

@guitargeek guitargeek changed the title [RF] cleanup RooLagrangianMorphFunc [RF] Cleanup RooLagrangianMorphFunc Jul 1, 2022
@guitargeek guitargeek force-pushed the roolagrangianmorphfunc-cleanup branch from ec6c0f5 to 1dbcf76 Compare July 1, 2022 16:11
@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@guitargeek guitargeek force-pushed the roolagrangianmorphfunc-cleanup branch from 1dbcf76 to 07e1a1a Compare July 1, 2022 16:15
@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@guitargeek guitargeek linked an issue Jul 1, 2022 that may be closed by this pull request
11 tasks
@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for al these improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RF] Various flaws in the RooLagrangianMorphFunc

4 participants