Skip to content

[cxxmodules] Added missing PushTransactionRAII to rootcling. #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgvassilev merged 1 commit into from
Sep 14, 2017
Merged

[cxxmodules] Added missing PushTransactionRAII to rootcling. #912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/dictgen/src/rootcling_impl.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3409,6 +3409,9 @@ std::list<std::string> RecordDecl2Headers(const clang::CXXRecordDecl &rcd,
{
std::list<std::string> headers;

// We push a new transaction because we could deserialize decls here
cling::Interpreter::PushTransactionRAII RAII(&interp);
Copy link
Member

@pcanal pcanal Aug 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know/understand which part of the code can deserialize? I.e. Can this be safely move to line 3422?


// Avoid infinite recursion
if (!visitedDecls.insert(rcd.getCanonicalDecl()).second)
return headers;
Expand Down