[cxxmodules] Added missing PushTransactionRAII to rootcling. #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With modules rootcling can now deserialize decls from this method, so we need to have a transaction when running this code.
|
Starting build on |
|
Build failed on ubuntu14/native. |
Member
|
LGTM if the bots are green. I'd expect, in long term, to avoid calling the entire routine. |
vgvassilev
approved these changes
Aug 31, 2017
pcanal
reviewed
Aug 31, 2017
| std::list<std::string> headers; | ||
|
|
||
| // We push a new transaction because we could deserialize decls here | ||
| cling::Interpreter::PushTransactionRAII RAII(&interp); |
Member
There was a problem hiding this comment.
Do we know/understand which part of the code can deserialize? I.e. Can this be safely move to line 3422?
Contributor
Author
|
@phsft-bot build |
|
Starting build on |
This was referenced Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With modules rootcling can now deserialize decls from this method,
so we need to have a transaction when running this code.