fix duplicate shadow doms in the recorder #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… elements in the replayer
…issues/detail?id=1352333 has duplicate shadow doms in the replayer
Juice10
approved these changes
Sep 16, 2022
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug description
In the recorder, some elements can be mutated and serialized multiple times. If they have attached shadow doms, these shadow doms can be also observed multiple times in the
shadow-dom-manager. Then children of shadow doms would be created multiple times causing duplicate elements in the replayer.For example:
The original page is on the left-hand side and the problematic page is on the RHS.
I also noticed a bug in the live-stream script. When navigating a page, the recorder would be executed twice and also cause duplicate shadow doms.
Solution
Add a set in the
shadow-dom-managerand check each shadow root before observing them.