Skip to content

fix duplicate shadow doms in the recorder #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2022
Merged

fix duplicate shadow doms in the recorder #1002

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
577bad2
fix: some shadow doms are observed multiple times and cause duplicate…
YunFeng0817 Sep 16, 2022
e4a9356
fix: in the live mode, the page https://bugs.chromium.org/p/chromium/…
YunFeng0817 Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: in the live mode, the page https://bugs.chromium.org/p/chromium/… 
…issues/detail?id=1352333 has duplicate shadow doms in the replayer
  • Loading branch information
@YunFeng0817
YunFeng0817 committed Sep 16, 2022
commit e4a9356d971e711524a7c8ad8d6a639478515c18
3 changes: 3 additions & 0 deletions packages/rrweb/scripts/stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,9 @@ void (async () => {
'window.__IS_RECORDING__',
);
if (!isRecording) {
// When the page navigates, I notice this event is emitted twice so that there are two recording processes running in a single page.
// Set recording flag True ASAP to prevent recording twice.
await recordedPage.evaluate('window.__IS_RECORDING__ = true');
await startRecording(recordedPage, serverURL);
}
});
Expand Down