Chore: Make tests less flakey & upgrade puppeteer to rrweb-snapshot test suite to run #1084
Conversation
Juice10
changed the title
Juice10
changed the title
| exports[`integration tests [html file]: iframe-inner.html 1`] = ` | ||
| "<!DOCTYPE html PUBLIC \\"-//W3C//DTD HTML 4.0 Transitional//EN\\"><html><head></head><body><button>inner iframe button</button> | ||
| "<html><head></head><body><button>inner iframe button</button> |
There was a problem hiding this comment.
These Transitional DOCTYPE here were added deliberately in #697
There was a problem hiding this comment.
Newer versions of Chrome strip them out if they aren’t in standards mode I think
There was a problem hiding this comment.
I had a moment to dig into what is going on. Newer versions of chrome don't add a transitional doctype if you never specified one to begin with. Chrome just leaves it empty.
iframe-inner.html:
what chrome renders:
I went through each of the changes in this PR and compared them to their source document and this does seem correct.
Example of the compat-mode.html file:
How chrome renders it:
(consistent with the snapshot)
There was a problem hiding this comment.
I'm not understanding!
The transitional doctypes are there in the source test files in order to test that the resultant replay also replays with compatMode=true
Maybe ye guys are one step ahead of me?
There was a problem hiding this comment.
There where never any doctypes in the source files. Not having doctypes also triggers compat-mode. Check this out:
There was a problem hiding this comment.
Ah okay got it now!
Only problem I can think of is if future versions of Chrome decide that lack of a doctype should imply HTML5 ... but happy to defer worrying about that to the future.
Tests randomly fail making it very hard to figure out if a PR broke something. This PR fixes a lot of that