Skip to content

Chore: Make tests less flakey & upgrade puppeteer to rrweb-snapshot test suite to run #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 10, 2023
Merged

Chore: Make tests less flakey & upgrade puppeteer to rrweb-snapshot test suite to run #1084

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d3bb6fb
Upgrade puppeteer to 17.1.3 in rrweb-snapshot
Juice10 Jan 6, 2023
05587c1
Apply formatting changes
Juice10 Jan 6, 2023
483e0bb
Add ?
Juice10 Jan 6, 2023
2b9842d
Make tests less flakey
Juice10 Jan 6, 2023
39821ae
Make attribute-setting more explicit
Juice10 Jan 6, 2023
d6b2374
Make test less flakey
Juice10 Jan 6, 2023
de74a19
Make test less flakey
Juice10 Jan 6, 2023
c8b2da4
Upgrade puppeteer for rrdom
Juice10 Jan 6, 2023
875b3dc
Use wait for request animation frame instead of timeout
Juice10 Jan 6, 2023
7ce90b3
Force append to happen in second event
Juice10 Jan 9, 2023
18fec80
Wait till iframe was loaded (now 100ms)
Juice10 Jan 9, 2023
0ce9db9
Round the currentTime to 1 decimal place
Juice10 Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wait till iframe was loaded (now 100ms)
  • Loading branch information
@Juice10
Juice10 committed Jan 9, 2023
commit 18fec80254c2b5aa6be388188c7bac8e184e7a19
2 changes: 1 addition & 1 deletion packages/rrweb/test/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ describe('record integration tests', function (this: ISuite) {
await page.goto('about:blank');
await page.setContent(getHtml.call(this, 'frame2.html'));

await page.waitForTimeout(10); // wait till frame was added to dom
await page.waitForSelector('iframe'); // wait for iframe to get added
await waitForRAF(page); // wait till browser loaded contents of frame

await page.evaluate(() => {
Expand Down