Fix performance of splitCssText by eoghanmurray · Pull Request #1615 · rrweb-io/rrweb

Fix bug where the right split point was not being picked for the 3rd section onwards

eoghanmurray

committed

Add test to put splitCssText through it's paces with a large file

eoghanmurray

committed

Introduce a limit which causes the 'efficiently' test to fail

eoghanmurray

committed

Fix that it wasn't able to find a split when both halves were identical

eoghanmurray

committed

Fix poor 'crawling' performance in this part of the algorithm for large css texts - e.g. for a (doubled) benchmark.css, we were running normalizeCssText 9480 times before k got to the right place

eoghanmurray

committed

Need to take larger jumps to be efficient; use the scaling factor to make better guess at how big a jump to make

eoghanmurray

committed

Add changeset

eoghanmurray

committed

Presuming the match on a character is more eficient than the indexOf here

eoghanmurray

committed

Fix eslint

eoghanmurray

committed

Update puppeteer to try to solve the following issue in github actions:

eoghanmurray

committed

Bump Chrome to see if it solves following issue in github actions:

eoghanmurray

committed

Both Firefox and the 131 version of Chrome I've upgraded to remove default css values from shorthand properties when retrieved via `sheet.rules[0].cssText`

eoghanmurray

committed

Drop chrome down again as getting overwhelmed with issues so will see if this LTS version also solves:

eoghanmurray

committed

Bump all puppeteer to match the LTS version of chrome we've just specified - going by https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

eoghanmurray

committed

Fix json error

eoghanmurray

committed

The previous version combo didn't install, trying next one up

eoghanmurray

committed

Still getting 'zygote_host_impl_linux.cc(128)] No usable sandbox!' so iterating through versions

eoghanmurray

committed

Keep searching through https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

eoghanmurray

committed

Following https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md

eoghanmurray

committed

Continuing with https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md

eoghanmurray

committed

Another bump to find minimum version to remove the 'No Usable Sandbox' error

eoghanmurray

committed

Final bump to top of https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

eoghanmurray

committed

Further bump of Chrome as issue still isn't solved - this previously seemed to solve things

eoghanmurray

committed

Revert all puppeteer and chrome related changes as the problem was fixed with `runs-on: ubuntu-22.04`

eoghanmurray

committed

I keep accidentally forgetting camelCase

eoghanmurray

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix performance of splitCssText #1615

Fix performance of splitCssText #1615
eoghanmurray merged 25 commits intorrweb-io:masterfrom
eoghanmurray:fix-1603

Commits on Jan 10, 2025

Fix bug where the right split point was not being picked for the 3rd section onwards

Add test to put splitCssText through it's paces with a large file

Introduce a limit which causes the 'efficiently' test to fail

Fix that it wasn't able to find a split when both halves were identical

Fix poor 'crawling' performance in this part of the algorithm for large css texts - e.g. for a (doubled) benchmark.css, we were running normalizeCssText 9480 times before k got to the right place

Need to take larger jumps to be efficient; use the scaling factor to make better guess at how big a jump to make

Add changeset

Presuming the match on a character is more eficient than the indexOf here

Fix eslint

Update puppeteer to try to solve the following issue in github actions:

Bump Chrome to see if it solves following issue in github actions:

Both Firefox and the 131 version of Chrome I've upgraded to remove default css values from shorthand properties when retrieved via `sheet.rules[0].cssText`

Drop chrome down again as getting overwhelmed with issues so will see if this LTS version also solves:

Bump all puppeteer to match the LTS version of chrome we've just specified - going by https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

Fix json error

The previous version combo didn't install, trying next one up

Still getting 'zygote_host_impl_linux.cc(128)] No usable sandbox!' so iterating through versions

Keep searching through https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

Following https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md

Continuing with https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md

Another bump to find minimum version to remove the 'No Usable Sandbox' error

Final bump to top of https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

Further bump of Chrome as issue still isn't solved - this previously seemed to solve things

Revert all puppeteer and chrome related changes as the problem was fixed with `runs-on: ubuntu-22.04`

I keep accidentally forgetting camelCase

Uh oh!

Fix performance of splitCssText #1615eoghanmurray merged 25 commits intorrweb-io:masterrrweb-io/rrweb:masterfrom eoghanmurray:fix-1603eoghanmurray/rrweb:fix-1603Copy head branch name to clipboard

Commits

Commits on Jan 10, 2025

Fix performance of splitCssText #1615
eoghanmurray merged 25 commits intorrweb-io:masterfrom
eoghanmurray:fix-1603