Skip to content

Fix mutation edge case when blocked class gets unblocked #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2022
Merged

Fix mutation edge case when blocked class gets unblocked #867

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7adc4ca
Fix mutation edge case when blocked class gets unblocked
rahulrelicx Mar 31, 2022
b798019
Add integration test
rahulrelicx Apr 14, 2022
627d205
Rebase and merge
rahulrelicx Apr 14, 2022
d1b0d22
Update isSerialized logic
rahulrelicx Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix mutation edge case when blocked class gets unblocked
  • Loading branch information
@rahulrelicx
rahulrelicx committed Mar 31, 2022
commit 7adc4ca0f792ead52638c6b6d4b1bcd52fc51245
3 changes: 2 additions & 1 deletion packages/rrweb/src/record/mutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
isBlocked,
isAncestorRemoved,
isIgnored,
isSerialized,
isIframeINode,
hasShadowRoot,
} from '../utils';
Expand Down Expand Up @@ -532,7 +533,7 @@ export default class MutationBuffer {
const parentId = isShadowRoot(m.target)
? this.mirror.getId((m.target.host as unknown) as INode)
: this.mirror.getId(m.target as INode);
if (isBlocked(m.target, this.blockClass) || isIgnored(n)) {
if (isBlocked(m.target, this.blockClass) || isIgnored(n) || !isSerialized(n)) {
return;
}
// removed node has not been serialized yet, just remove it from the Set
Expand Down
4 changes: 4 additions & 0 deletions packages/rrweb/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,10 @@ export function isBlocked(node: Node | null, blockClass: blockClass): boolean {
return isBlocked(node.parentNode, blockClass);
}

export function isSerialized(n: Node | INode): boolean {
return '__sn' in n;
}

export function isIgnored(n: Node | INode): boolean {
if ('__sn' in n) {
return (n as INode).__sn.id === IGNORED_NODE;
Expand Down