Skip to content

Fix mutation edge case when blocked class gets unblocked #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2022
Merged

Fix mutation edge case when blocked class gets unblocked #867

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7adc4ca
Fix mutation edge case when blocked class gets unblocked
rahulrelicx Mar 31, 2022
b798019
Add integration test
rahulrelicx Apr 14, 2022
627d205
Rebase and merge
rahulrelicx Apr 14, 2022
d1b0d22
Update isSerialized logic
rahulrelicx Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update isSerialized logic
  • Loading branch information
@rahulrelicx
rahulrelicx committed Apr 14, 2022
commit d1b0d2236ca99af4abd1da2545ac13049bedfa26
2 changes: 1 addition & 1 deletion packages/rrweb/src/record/mutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ export default class MutationBuffer {
if (
isBlocked(m.target, this.blockClass) ||
isIgnored(n, this.mirror) ||
!isSerialized(n)
!isSerialized(n, this.mirror)
) {
return;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/rrweb/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ export function isBlocked(node: Node | null, blockClass: blockClass): boolean {
return isBlocked(node.parentNode, blockClass);
}

export function isSerialized(n: Node): boolean {
return '__sn' in n;
export function isSerialized(n: Node, mirror: Mirror): boolean {
return mirror.getId(n) !== -1;
}

export function isIgnored(n: Node, mirror: Mirror): boolean {
Expand Down