Fix issue with scrolling not working

[eoghanmurray]

Fix issue where only indication I could see in any attribute that the document was scrolling was on window.pageYOffset, so we hadn't been able to replay scrolling

Website was https://www.malibal.com/boutique/pc/configurePrd.asp?idproduct=2061

I've no idea what conditions make this the case.

[Yuyz0112]

LGTM, we can merge this after the CI passed

[YunFeng0817]

The CI failed just because of some TS errors. I fixed these errors in the comments and wish these can help you.

[YunFeng0817]

Suggested change

	initialOffset: getWindowScroll(window),
	initialOffset: getWindowScroll(window.document),

[eoghanmurray]

Hi Mark, thanks for this review! What is the idea behind switching to document rather than window? I'm happy with either, just curious.
We could probably change it to getDocumentScroll too; I'm just wondering about the semantics of it.

[YunFeng0817]

document.defaultView is nullable but window.document always exists.
If the parameter is a window and the window is null, the function can't retrieve a document object from it (win.document = null.document). The document and window can both be null. This is the reason those TS errors occurred.
I think renaming with getDocumentScroll is a good idea.

[YunFeng0817]

Suggested change

	const scrollLeftTop = getWindowScroll(doc.defaultView);
	const scrollLeftTop = getWindowScroll(doc);

[YunFeng0817]

Suggested change

	export function getWindowScroll(win): number {
	const doc = win.document;
	return {
	left:
	doc.scrollingElement ? doc.scrollingElement.scrollLeft
	: win.pageXOffset !== undefined
	? win.pageXOffset
	: doc?.documentElement.scrollLeft ||
	doc?.body?.parentElement?.scrollLeft ||
	doc?.body.scrollLeft ||
	0,
	top:
	doc.scrollingElement ? doc.scrollingElement.scrollTop
	: win.pageYOffset !== undefined
	? win.pageYOffset
	: doc?.documentElement.scrollTop ||
	doc?.body?.parentElement?.scrollTop ||
	doc?.body.scrollTop ||
	0,
	}
	}
	export function getWindowScroll(doc: Document) {
	const win = doc.defaultView;
	return {
	left: doc.scrollingElement
	? doc.scrollingElement.scrollLeft
	: win?.pageXOffset !== undefined
	? win.pageXOffset
	: doc.documentElement.scrollLeft ||
	doc.body?.parentElement?.scrollLeft ||
	doc.body.scrollLeft ||
	0,
	top: doc.scrollingElement
	? doc.scrollingElement.scrollTop
	: win?.pageYOffset !== undefined
	? win.pageYOffset
	: doc.documentElement.scrollTop ||
	doc.body?.parentElement?.scrollTop ||
	doc.body.scrollTop ||
	0,
	};
	}

[YunFeng0817]

Close this because it is a duplicate of #1054