Adding defines and functions required for vxworks #4781
Conversation
|
@rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
|
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
LGTM! Could you please squash?
Co-authored-by: Immad Mir <[email protected]>
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@tgross35. CI test fails seems unrelated. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
| // unistd.h | ||
| pub fn setpgid(pid: pid_t, pgid: pid_t) -> pid_t; |
There was a problem hiding this comment.
Does vxworks actually deviate from posix here on the return type? https://pubs.opengroup.org/onlinepubs/009604599/functions/setpgid.html
There was a problem hiding this comment.
pid_t is an alias for c_int.
There was a problem hiding this comment.
There is no ABI-level difference, but do the headers actually call for a pid_t return? Seems unusual.
There was a problem hiding this comment.
I can confirm that setpgid (in VxWorks) does infact return "pid_t". It seems vxworks here deviates from posix.
tgross35
added
the
stable-nominated
Co-authored-by: Immad Mir <[email protected]> (backport <rust-lang#4781>) (cherry picked from commit 2bee2f3)
Link: rust-lang#4781 (comment) (backport <rust-lang#4781>) (cherry picked from commit 5a1ced6)
Co-authored-by: Immad Mir <[email protected]> (backport <#4781>) (cherry picked from commit 2bee2f3)
Link: #4781 (comment) (backport <#4781>) (cherry picked from commit 5a1ced6)
tgross35
added
stable-applied
5 participants
Description
Adding functions and defines required for vxworks. This supersedes #4676 .
In this PR we have guarded the struct stat, and sigaction in such a way that it works for older (< 25.09) as well as newer versions of vxworks.
Authors
Sources
VxWorks sources are copyrighted.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI