Skip to content

Remove ganache-cli related code from API & tests #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgewecke merged 7 commits into from
Feb 5, 2024
Merged

Remove ganache-cli related code from API & tests #849

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73ea1af
Remove ganache-cli related code from API & tests
cgewecke Feb 4, 2024
804ffb2
Remove detect-port dependency
cgewecke Feb 4, 2024
8d63775
Throw error when network flag set / remove util support for http client
cgewecke Feb 5, 2024
e7589a0
Remove default network integration test
cgewecke Feb 5, 2024
31498ec
Fix missing network name in util configuration
cgewecke Feb 5, 2024
9fffe0d
Update API docs for attachToHardhatVM
cgewecke Feb 5, 2024
fcfb966
Small API docs edits
cgewecke Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove default network integration test
  • Loading branch information
@cgewecke
cgewecke committed Feb 5, 2024
commit e7589a0ce6bb2b82b903ab71b8743500b4cf7c50
19 changes: 0 additions & 19 deletions test/integration/standard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,25 +53,6 @@ describe('Hardhat Plugin: standard use cases', function() {
);
});

it('default network ("hardhat")', async function(){
mock.install('Simple', 'simple.js', solcoverConfig);
mock.hardhatSetupEnv(this);

this.env.hardhatArguments.network = "hardhat"

await this.env.run("coverage");

assert(
mock.loggerOutput.val.includes("HardhatEVM"),
`Should have displayed HardhatEVM version: ${mock.loggerOutput.val}`
);

assert(
mock.loggerOutput.val.includes("hardhat"),
`Should have used 'hardhat' network name: ${mock.loggerOutput.val}`
);
});

it('uses inheritance', async function() {
mock.installDouble(
['Proxy', 'Owned'],
Expand Down