Skip to content

Remove ganache-cli related code from API & tests #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgewecke merged 7 commits into from
Feb 5, 2024
Merged

Remove ganache-cli related code from API & tests #849

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73ea1af
Remove ganache-cli related code from API & tests
cgewecke Feb 4, 2024
804ffb2
Remove detect-port dependency
cgewecke Feb 4, 2024
8d63775
Throw error when network flag set / remove util support for http client
cgewecke Feb 5, 2024
e7589a0
Remove default network integration test
cgewecke Feb 5, 2024
31498ec
Fix missing network name in util configuration
cgewecke Feb 5, 2024
9fffe0d
Update API docs for attachToHardhatVM
cgewecke Feb 5, 2024
fcfb966
Small API docs edits
cgewecke Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Small API docs edits
  • Loading branch information
@cgewecke
cgewecke committed Feb 5, 2024
commit fcfb96685680f6269ad9493ab824d8d02a43ede7
8 changes: 4 additions & 4 deletions docs/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ table below shows how its core methods relate to the stages of a test run:
| Test Stage <img width=200/> | API Method <img width=200/> | Description <img width=800/> |
|---------------|--------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| compilation | `instrument` | A **pre-compilation** step: Rewrites contracts and generates an instrumentation data map. |
| client launch | `attachToHardhatVM` | A **substitute** step: Enables coverage collection enabled in a HardhatEVM client. As the client runs it will mark line/branch hits on the instrumentation data map. |
| client launch | `attachToHardhatVM` | A **pre-test** step: Enables coverage collection enabled in a HardhatEVM client. As the client runs it will mark line/branch hits on the instrumentation data map. |
| test | `report` | A **post-test** step: Generates a coverage report from the data collected by the VM after tests complete. |
| exit | `finish` | A **substitute** step: Shuts client down |


[3]: https://github.com/gotwarlost/istanbul

Expand All @@ -20,8 +20,8 @@ table below shows how its core methods relate to the stages of a test run:
disposable set of contracts/artifacts which coverage must use in lieu of the 'real' (uninstrumented)
contracts.

+ there are two complete [coverage tool/plugin implementations][5] (for Hardhat and Truffle)
which can be used as sources if you're building something similar.
+ there is a complete [coverage tool/plugin implementation][5] for Hardhat
which can be used as a source if you're building something similar.

[5]: https://github.com/sc-forks/solidity-coverage/tree/master/plugins

Expand Down