Add client configurations #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dk1027
reviewed
May 10, 2019
| return NewWithConfig(writeKey, Config{}) | ||
| } | ||
|
|
||
| func NewWithConfig(writeKey string, config Config) *Client { |
There was a problem hiding this comment.
What do you think if Config contains the writeKey?
func New(writeKey string) *Client {
return NewWithConfig(Config{WriteKey: writeKey})
}
func NewWithConfig(config Config) *Client {
...
}
Contributor
Author
There was a problem hiding this comment.
Configs tend to imply optionality. The writekey is not optional. I am not sure it belongs in the config
dk1027
reviewed
May 10, 2019
client.go
Outdated
| } | ||
| } | ||
|
|
||
| func getFinalConfig(c Config) Config { |
There was a problem hiding this comment.
getFinalConfig doesn't really explain much.
Could you consider rename/refactor to
func applyDefaultConfig(c *Config){
// sets default inline
}
Contributor
Author
There was a problem hiding this comment.
naming is hard. How do parents do this
Source config
* Release v0.0.2-webhookfn * hide sensitive payload request. support PrintErrors using Config * update message * Release v1.0.0-webhookfn
* origin/master: Fix time.Ticker leak in Client go fmt dep -> go module
tysonmote
approved these changes
Jul 12, 2021
Contributor
|
I'm going to merge and tag this release as v2.0.0 because it's a breaking API change (albeit minor). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new function to allow creating clients with configurations