Skip to content

Add client configurations #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tysonmote merged 8 commits into from
Jul 12, 2021
Merged

Add client configurations #9

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bbe28d7
Add client configurations
ynguyensegment May 10, 2019
67871b0
support Source config
prayansh Aug 27, 2019
d215214
Release v0.0.1-webhookfn
ynguyensegment Aug 30, 2019
e45274c
Merge pull request #10 from segmentio/source-config
prayansh Aug 30, 2019
8795017
Patch objects-go (remove sensitive logs) (#11)
prayansh Oct 2, 2019
e52e2a8
Merge remote-tracking branch 'origin/master' into client_configs
tysonmote Jul 12, 2021
7d5a623
History.md
tysonmote Jul 12, 2021
28ae668
Rename function for clarity
tysonmote Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename function for clarity
  • Loading branch information
@tysonmote
tysonmote committed Jul 12, 2021
commit 28ae6688998801e36e75296018ba2e245e5605c0
5 changes: 2 additions & 3 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,15 @@ func New(writeKey string) *Client {
}

func NewWithConfig(writeKey string, config Config) *Client {
Copy link

@dk1027 dk1027 May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think if Config contains the writeKey?

func New(writeKey string) *Client {
  return NewWithConfig(Config{WriteKey: writeKey})
}

func NewWithConfig(config Config) *Client {
...
}

Copy link
Contributor Author

@ynguyensegment ynguyensegment May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configs tend to imply optionality. The writekey is not optional. I am not sure it belongs in the config

conf := getFinalConfig(config)
return &Client{
Config: conf,
Config: withDefaults(config),
writeKey: writeKey,
cmap: newConcurrentMap(),
semaphore: make(semaphore.Semaphore, 10),
}
}

func getFinalConfig(c Config) Config {
func withDefaults(c Config) Config {
if c.BaseEndpoint == "" {
c.BaseEndpoint = DefaultBaseEndpoint
}
Expand Down