fix: add modal prop to Select component (#10074)#10253
Open
aakarsh12x wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix: add modal prop to Select component (#10074)#10253aakarsh12x wants to merge 1 commit intoshadcn-ui:mainfrom
aakarsh12x wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
Contributor
|
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a
Selectcomponent inside a portaled layout (likeSidebar/SidebarInset) currently triggers an accessibility warning:Blocked aria-hidden on an element because its descendant retained focus.This occurs because Radix's
hideOthersutility marks the application root asaria-hiddenwhile focus is still transitioning from theSelectTrigger.This PR explicitly adds the
modalprop to theSelectcomponent in the registry. This allows consumers to setmodal={false}, effectively disabling thehideOthersbehavior and resolving the accessibility warning in complex/portaled layouts.