Skip to content

fix: add modal prop to Select component (#10074) #10253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aakarsh12x wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix: add modal prop to Select component (#10074) #10253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: add modal prop to Select component (#10074)
  • Loading branch information
Aakarsh committed Apr 1, 2026
commit d10b2644404df0399732516bc84d4281c37d706a
3 changes: 2 additions & 1 deletion apps/v4/registry/bases/radix/ui/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ import { cn } from "@/registry/bases/radix/lib/utils"
import { IconPlaceholder } from "@/app/(create)/components/icon-placeholder"

function Select({
modal = true,
...props
}: React.ComponentProps<typeof SelectPrimitive.Root>) {
return <SelectPrimitive.Root data-slot="select" {...props} />
return <SelectPrimitive.Root data-slot="select" modal={modal} {...props} />
}

function SelectGroup({
Expand Down
3 changes: 2 additions & 1 deletion apps/v4/registry/new-york-v4/ui/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ import { Select as SelectPrimitive } from "radix-ui"
import { cn } from "@/lib/utils"

function Select({
modal = true,
...props
}: React.ComponentProps<typeof SelectPrimitive.Root>) {
return <SelectPrimitive.Root data-slot="select" {...props} />
return <SelectPrimitive.Root data-slot="select" modal={modal} {...props} />
}

function SelectGroup({
Expand Down