[Core] switch_core_session_parse_crypto_prefs: check match with suite alias as well #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing the user given cypto type string to both name and alias of the default crypto suites supported by the system.
andywolk
changed the title
andywolk
approved these changes
Nov 16, 2020
andywolk
requested changes
Nov 16, 2020
|
|
||
| for (j = 0; j < CRYPTO_INVALID; j++) { | ||
| if (!strcasecmp(fields[i], SUITES[j].name)) { | ||
| if (!strcasecmp(fields[i], SUITES[j].name) || !strcasecmp(fields[i], SUITES[j].alias)) { |
Contributor
There was a problem hiding this comment.
Shouldn't we use switch_core_media_crypto_str2type() here instead of the whole block?
|
This page defines cyptro suites: https://freeswitch.org/confluence/display/FREESWITCH/rtp_secure_media. Some of the encryption suite entries are aliases, some are not aliases. For a TLS/SRTP call, if the user specifies a crypto suite that is an alias from the list mentioned in the document negotiation will fail. This patch allows the user to specify either an encryption suite name OR and alias. |
Contributor
|
@Five9Voice Please resolve the requested change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing the user given cypto type string to both name and alias of the default crypto suites supported by the system.