Skip to content

[Core] switch_core_session_parse_crypto_prefs: check match with suite alias as well #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajay-sabat wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

[Core] switch_core_session_parse_crypto_prefs: check match with suite alias as well #951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/switch_core_media.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1761,7 +1761,7 @@ static void switch_core_session_parse_crypto_prefs(switch_core_session_t *sessio
int ok = 0;

for (j = 0; j < CRYPTO_INVALID; j++) {
if (!strcasecmp(fields[i], SUITES[j].name)) {
if (!strcasecmp(fields[i], SUITES[j].name) || !strcasecmp(fields[i], SUITES[j].alias)) {
Copy link
Contributor

@andywolk andywolk Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use switch_core_media_crypto_str2type() here instead of the whole block?

smh->crypto_suite_order[k++] = SUITES[j].type;
ok++;
break;
Expand Down